fpdfsdk/jsapi/fxjs_v8.cpp - Issue 1831723004: Re-land "Preserve m_pDynamicObjsMap until FXJS_PerIsolateData is destroyed.""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/jsapi/fxjs_v8.cpp

Issue 1831723004: Re-land "Preserve m_pDynamicObjsMap until FXJS_PerIsolateData is destroyed."" (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Change destruction order. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/jsapi/fxjs_v8.cpp

diff --git a/fpdfsdk/jsapi/fxjs_v8.cpp b/fpdfsdk/jsapi/fxjs_v8.cpp

index 473b54631842a3533ce0fa6d5bea4e29ba016c8a..034f2c6642356a3b1f7c658992d7ed752440728c 100644

--- a/fpdfsdk/jsapi/fxjs_v8.cpp

+++ b/fpdfsdk/jsapi/fxjs_v8.cpp

@@ -374,7 +374,6 @@ void FXJS_ReleaseRuntime(v8::Isolate* pIsolate,

FXJS_PerIsolateData* pData = FXJS_PerIsolateData::Get(pIsolate);

if (!pData)

return;

- pData->ReleaseDynamicObjsMap();

int maxID = CFXJS_ObjDefinition::MaxID(pIsolate);

for (int i = 0; i < maxID; ++i) {

@@ -399,6 +398,7 @@ void FXJS_ReleaseRuntime(v8::Isolate* pIsolate,

if (pIsolate == g_isolate && --g_isolate_ref_count > 0)

return;

+ pData->ReleaseDynamicObjsMap();

for (int i = 0; i < maxID; ++i)

delete CFXJS_ObjDefinition::ForID(pIsolate, i);

« no previous file with comments | « fpdfsdk/include/jsapi/fxjs_v8.h ('k') | fpdfsdk/jsapi/fxjs_v8_embeddertest.cpp » ('j') | no next file with comments »