fpdfsdk/include/jsapi/fxjs_v8.h - Issue 1831723004: Re-land "Preserve m_pDynamicObjsMap until FXJS_PerIsolateData is destroyed.""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/include/jsapi/fxjs_v8.h

Issue 1831723004: Re-land "Preserve m_pDynamicObjsMap until FXJS_PerIsolateData is destroyed."" (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Change destruction order. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: fpdfsdk/include/jsapi/fxjs_v8.h

diff --git a/fpdfsdk/include/jsapi/fxjs_v8.h b/fpdfsdk/include/jsapi/fxjs_v8.h

index dad1eaa8886022ca648ee7afd3ca760c0e29f1b2..00107ef7e5620ec1a0bd94d1d89e8d217fb6d51f 100644

--- a/fpdfsdk/include/jsapi/fxjs_v8.h

+++ b/fpdfsdk/include/jsapi/fxjs_v8.h

@@ -97,7 +97,8 @@ class FXJS_PerIsolateData {

static void SetUp(v8::Isolate* pIsolate);

static FXJS_PerIsolateData* Get(v8::Isolate* pIsolate);

void CreateDynamicObjsMap(v8::Isolate* pIsolate) {

- m_pDynamicObjsMap = new V8TemplateMap(pIsolate);

+ if (!m_pDynamicObjsMap)

+ m_pDynamicObjsMap = new V8TemplateMap(pIsolate);

}

void ReleaseDynamicObjsMap() {

delete m_pDynamicObjsMap;

« no previous file with comments | « no previous file | fpdfsdk/jsapi/fxjs_v8.cpp » ('j') | no next file with comments »