Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1831723004: Re-land "Preserve m_pDynamicObjsMap until FXJS_PerIsolateData is destroyed."" (Closed)

Created:
4 years, 9 months ago by Tom Sepez
Modified:
4 years, 8 months ago
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Re-land "Preserve m_pDynamicObjsMap until FXJS_PerIsolateData is destroyed."" Fix the destruction order. This reverts commit 129a60ec2d4d98ed953beaca629c99a52fb7e9b0. BUG=594120 TBR=jochen@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/9967cc5861fbff894eed8fca40e1e5ed524b04c6

Patch Set 1 : Original Patch #

Patch Set 2 : Change destruction order. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -10 lines) Patch
M fpdfsdk/include/jsapi/fxjs_v8.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M fpdfsdk/jsapi/fxjs_v8.cpp View 1 2 chunks +1 line, -1 line 0 comments Download
M fpdfsdk/jsapi/fxjs_v8_embeddertest.cpp View 2 chunks +66 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Tom Sepez
Jochen, try #2. Please review. Thanks.
4 years, 9 months ago (2016-03-24 17:33:02 UTC) #3
Tom Sepez
On 2016/03/24 17:33:02, Tom Sepez wrote: > Jochen, try #2. Please review. Thanks. Moving to ...
4 years, 9 months ago (2016-03-24 18:37:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1831723004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1831723004/20001
4 years, 9 months ago (2016-03-24 18:38:45 UTC) #7
commit-bot: I haz the power
Failed to commit the patch.
4 years, 9 months ago (2016-03-24 18:39:05 UTC) #9
Tom Sepez
Committed patchset #2 (id:20001) manually as 9967cc5861fbff894eed8fca40e1e5ed524b04c6 (presubmit successful).
4 years, 9 months ago (2016-03-24 18:45:42 UTC) #11
Tom Sepez
4 years, 8 months ago (2016-04-05 18:37:03 UTC) #12
Message was sent while issue was closed.
Seems reasonable. LGTM.

Powered by Google App Engine
This is Rietveld 408576698