Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 1831673002: [MD] Apply appropriate call to action styling to infobar buttons. (Closed)

Created:
4 years, 9 months ago by Evan Stade
Modified:
4 years, 8 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD] Apply appropriate call to action styling to infobar buttons. BUG=596238 Committed: https://crrev.com/5d04bab763700c788f8084337e70a805be2ffa2d Cr-Commit-Position: refs/heads/master@{#383545}

Patch Set 1 #

Patch Set 2 : compile #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -32 lines) Patch
M chrome/browser/ui/views/infobars/confirm_infobar.cc View 1 3 chunks +31 lines, -5 lines 2 comments Download
M chrome/browser/ui/views/infobars/infobar_view.h View 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/ui/views/infobars/infobar_view.cc View 1 chunk +31 lines, -26 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1831673002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1831673002/1
4 years, 9 months ago (2016-03-23 22:54:00 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/143961) linux_chromium_chromeos_rel_ng on ...
4 years, 9 months ago (2016-03-23 23:09:13 UTC) #4
Evan Stade
4 years, 9 months ago (2016-03-24 21:26:05 UTC) #6
Peter Kasting
LGTM https://codereview.chromium.org/1831673002/diff/10001/chrome/browser/ui/views/infobars/confirm_infobar.cc File chrome/browser/ui/views/infobars/confirm_infobar.cc (right): https://codereview.chromium.org/1831673002/diff/10001/chrome/browser/ui/views/infobars/confirm_infobar.cc#newcode87 chrome/browser/ui/views/infobars/confirm_infobar.cc:87: } Nit: It seems unfortunate to have this ...
4 years, 9 months ago (2016-03-25 04:57:48 UTC) #7
Evan Stade
https://codereview.chromium.org/1831673002/diff/10001/chrome/browser/ui/views/infobars/confirm_infobar.cc File chrome/browser/ui/views/infobars/confirm_infobar.cc (right): https://codereview.chromium.org/1831673002/diff/10001/chrome/browser/ui/views/infobars/confirm_infobar.cc#newcode87 chrome/browser/ui/views/infobars/confirm_infobar.cc:87: } On 2016/03/25 04:57:48, Peter Kasting wrote: > Nit: ...
4 years, 8 months ago (2016-03-28 19:13:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1831673002/10001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1831673002/10001
4 years, 8 months ago (2016-03-28 19:14:10 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:10001)
4 years, 8 months ago (2016-03-28 19:55:53 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-03-28 19:58:09 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5d04bab763700c788f8084337e70a805be2ffa2d
Cr-Commit-Position: refs/heads/master@{#383545}

Powered by Google App Engine
This is Rietveld 408576698