Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: chrome/browser/ui/views/infobars/infobar_view.cc

Issue 1831673002: [MD] Apply appropriate call to action styling to infobar buttons. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: compile Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/infobars/infobar_view.cc
diff --git a/chrome/browser/ui/views/infobars/infobar_view.cc b/chrome/browser/ui/views/infobars/infobar_view.cc
index b0012dc05b02af4bc2c6072ce4d2f8a461c50246..fad1cb36e7d8bee734eec8a9437f4d173d5fe781 100644
--- a/chrome/browser/ui/views/infobars/infobar_view.cc
+++ b/chrome/browser/ui/views/infobars/infobar_view.cc
@@ -133,33 +133,38 @@ views::Link* InfoBarView::CreateLink(const base::string16& text,
views::LabelButton* InfoBarView::CreateTextButton(
views::ButtonListener* listener,
const base::string16& text) {
- views::LabelButton* button = nullptr;
- if (ui::MaterialDesignController::IsModeMaterial()) {
- button = views::MdTextButton::CreateStandardButton(listener, text);
- } else {
- button = new views::LabelButton(listener, text);
-
- scoped_ptr<views::LabelButtonAssetBorder> button_border(
- new views::LabelButtonAssetBorder(views::Button::STYLE_TEXTBUTTON));
- const int kNormalImageSet[] = IMAGE_GRID(IDR_INFOBARBUTTON_NORMAL);
- button_border->SetPainter(
- false, views::Button::STATE_NORMAL,
- views::Painter::CreateImageGridPainter(kNormalImageSet));
- const int kHoveredImageSet[] = IMAGE_GRID(IDR_INFOBARBUTTON_HOVER);
- button_border->SetPainter(
- false, views::Button::STATE_HOVERED,
- views::Painter::CreateImageGridPainter(kHoveredImageSet));
- const int kPressedImageSet[] = IMAGE_GRID(IDR_INFOBARBUTTON_PRESSED);
- button_border->SetPainter(
- false, views::Button::STATE_PRESSED,
- views::Painter::CreateImageGridPainter(kPressedImageSet));
- button->SetBorder(std::move(button_border));
- button->set_animate_on_state_change(false);
- ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
- button->SetFontList(rb.GetFontList(ui::ResourceBundle::MediumFont));
- button->SetFocusable(true);
- }
+ DCHECK(!ui::MaterialDesignController::IsModeMaterial());
+ views::LabelButton* button = new views::LabelButton(listener, text);
+ scoped_ptr<views::LabelButtonAssetBorder> button_border(
+ new views::LabelButtonAssetBorder(views::Button::STYLE_TEXTBUTTON));
+ const int kNormalImageSet[] = IMAGE_GRID(IDR_INFOBARBUTTON_NORMAL);
+ button_border->SetPainter(
+ false, views::Button::STATE_NORMAL,
+ views::Painter::CreateImageGridPainter(kNormalImageSet));
+ const int kHoveredImageSet[] = IMAGE_GRID(IDR_INFOBARBUTTON_HOVER);
+ button_border->SetPainter(
+ false, views::Button::STATE_HOVERED,
+ views::Painter::CreateImageGridPainter(kHoveredImageSet));
+ const int kPressedImageSet[] = IMAGE_GRID(IDR_INFOBARBUTTON_PRESSED);
+ button_border->SetPainter(
+ false, views::Button::STATE_PRESSED,
+ views::Painter::CreateImageGridPainter(kPressedImageSet));
+ button->SetBorder(std::move(button_border));
+ button->set_animate_on_state_change(false);
+ ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
+ button->SetFontList(rb.GetFontList(ui::ResourceBundle::MediumFont));
+ button->SetFocusable(true);
+ button->SetTextColor(views::Button::STATE_NORMAL, GetInfobarTextColor());
+ button->SetTextColor(views::Button::STATE_HOVERED, GetInfobarTextColor());
+ return button;
+}
+views::MdTextButton* InfoBarView::CreateMdTextButton(
+ views::ButtonListener* listener,
+ const base::string16& text) {
+ DCHECK(ui::MaterialDesignController::IsModeMaterial());
+ views::MdTextButton* button =
+ views::MdTextButton::CreateMdButton(listener, text);
button->SetTextColor(views::Button::STATE_NORMAL, GetInfobarTextColor());
button->SetTextColor(views::Button::STATE_HOVERED, GetInfobarTextColor());
return button;

Powered by Google App Engine
This is Rietveld 408576698