Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 1831653002: Don't allow a leading plus in ports for proxy bypass rules. (Closed)

Created:
4 years, 9 months ago by eroman
Modified:
4 years, 9 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't allow a leading plus in ports for proxy bypass rules. For instance will reject the rule "*.org:+443" whereas before it would be accepted. BUG=596523, 596570 Committed: https://crrev.com/55fa65c5ce1c15d8a492d6876b2324fd576a83a4 Cr-Commit-Position: refs/heads/master@{#383111}

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M net/proxy/proxy_bypass_rules.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M net/proxy/proxy_bypass_rules_unittest.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1831653002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1831653002/1
4 years, 9 months ago (2016-03-23 22:40:13 UTC) #2
eroman
https://codereview.chromium.org/1831653002/diff/1/net/proxy/proxy_bypass_rules.cc File net/proxy/proxy_bypass_rules.cc (left): https://codereview.chromium.org/1831653002/diff/1/net/proxy/proxy_bypass_rules.cc#oldcode320 net/proxy/proxy_bypass_rules.cc:320: host = raw; This removal is not strictly part ...
4 years, 9 months ago (2016-03-23 22:41:53 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 9 months ago (2016-03-24 00:09:57 UTC) #7
mmenke
On 2016/03/24 00:09:57, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 9 months ago (2016-03-24 15:43:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1831653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1831653002/20001
4 years, 9 months ago (2016-03-24 17:45:15 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-24 18:57:58 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 19:00:24 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/55fa65c5ce1c15d8a492d6876b2324fd576a83a4
Cr-Commit-Position: refs/heads/master@{#383111}

Powered by Google App Engine
This is Rietveld 408576698