Don't allow a leading plus in ports for proxy bypass rules.

net/proxy/proxy_bypass_rules_unittest.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/proxy/proxy_bypass_rules.h"
 
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "net/proxy/proxy_config_service_common_unittest.h"
 #include "testing/gtest/include/gtest/gtest.h"
@@ skipping 79 matching lines @@
   EXPECT_EQ("*.org:443", rules.rules()[0]->ToString());
 
   EXPECT_TRUE(rules.Matches(GURL("http://www.google.org:443")));
   EXPECT_TRUE(rules.Matches(GURL("https://www.google.org")));
 
   EXPECT_FALSE(rules.Matches(GURL("http://www.google.org")));
   EXPECT_FALSE(rules.Matches(GURL("https://www.google.com")));
   EXPECT_FALSE(rules.Matches(GURL("https://www.google.org.com")));
 }
 
+// Tests a codepath that parses hostnamepattern:port, where "port" is invalid
+// by containing a leading plus.
+TEST(ProxyBypassRulesTest, ParseInvalidPort) {
+  ProxyBypassRules rules;
+  EXPECT_TRUE(rules.AddRuleFromString("*.org:443"));
+  EXPECT_FALSE(rules.AddRuleFromString("*.com:+443"));
+  EXPECT_FALSE(rules.AddRuleFromString("*.com:-443"));
+}
+
 TEST(ProxyBypassRulesTest, IPV4Address) {
   ProxyBypassRules rules;
   rules.ParseFromString("192.168.1.1");
   ASSERT_EQ(1u, rules.rules().size());
   EXPECT_EQ("192.168.1.1", rules.rules()[0]->ToString());
 
   EXPECT_TRUE(rules.Matches(GURL("http://192.168.1.1")));
   EXPECT_TRUE(rules.Matches(GURL("https://192.168.1.1:90")));
 
   EXPECT_FALSE(rules.Matches(GURL("http://www.google.com")));
@@ skipping 196 matching lines @@
   EXPECT_EQ("a:b:c:d::/48", rules.rules()[0]->ToString());
 
   EXPECT_TRUE(rules.Matches(GURL("http://[A:b:C:9::]")));
   EXPECT_FALSE(rules.Matches(GURL("http://foobar.com")));
   EXPECT_FALSE(rules.Matches(GURL("http://192.169.1.1")));
 }
 
 }  // namespace
 
 }  // namespace net