Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 1831623002: Changes lifetime of apps with the "all_users" capability (Closed)

Created:
4 years, 9 months ago by sky
Modified:
4 years, 9 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changes lifetime of apps with the "all_users" capability This changes makes it so "all_users" apps are owned by the shell. BUG=597385 TEST=none R=ben@chromium.org Committed: https://crrev.com/8526ab53583e2cc6390fb4693132b151d2481ea1 Cr-Commit-Position: refs/heads/master@{#382951}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M mojo/shell/shell.cc View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
sky
I didn't write a test for this as I'm not sure this is the right ...
4 years, 9 months ago (2016-03-23 21:11:50 UTC) #1
Ben Goodger (Google)
lgtm This makes sense. I was thinking we'd need to do something like this.
4 years, 9 months ago (2016-03-23 21:16:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1831623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1831623002/1
4 years, 9 months ago (2016-03-23 21:36:07 UTC) #4
commit-bot: I haz the power
Failed to apply the patch.
4 years, 9 months ago (2016-03-23 22:32:41 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 22:33:09 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8526ab53583e2cc6390fb4693132b151d2481ea1
Cr-Commit-Position: refs/heads/master@{#382951}

Powered by Google App Engine
This is Rietveld 408576698