Changes lifetime of apps with the "all_users" capability

mojo/shell/shell.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/shell/shell.h"
 
 #include <stdint.h>
 
 #include <utility>
 
@@ skipping 694 matching lines @@
   Identity source = params->source();
   // |capabilities_ptr| can be null when there is no manifest, e.g. for URL
   // types not resolvable by the resolver.
   CapabilitySpec capabilities = GetPermissiveCapabilities();
   if (!capabilities_ptr.is_null())
     capabilities = capabilities_ptr.To<CapabilitySpec>();
 
   // Clients that request "all_users" class from the shell are allowed to
   // field connection requests from any user. They also run with a synthetic
   // user id generated here. The user id provided via Connect() is ignored.
+  // Additionally apps with the "all_users" class are not tied to the lifetime
+  // of the app that connected to them, instead they are owned by the shell.
+  Identity source_identity_for_creation;
   if (HasClass(capabilities, kCapabilityClass_AllUsers)) {
     singletons_.insert(target.name());
     target.set_user_id(base::GenerateGUID());
+    source_identity_for_creation = CreateShellIdentity();
+  } else {
+    source_identity_for_creation = params->source();
   }
 
   mojom::ClientProcessConnectionPtr client_process_connection =
       params->TakeClientProcessConnection();
-  Instance* instance = CreateInstance(params->source(), target, capabilities);
+  Instance* instance = CreateInstance(source_identity_for_creation,
+                                      target, capabilities);
 
   // Below are various paths through which a new Instance can be bound to a
   // ShellClient proxy.
   if (client.is_bound()) {
     // If a ShellClientPtr was provided, there's no more work to do: someone
     // is already holding a corresponding ShellClientRequest.
     instance->StartWithClient(std::move(client));
   } else if (!client_process_connection.is_null()) {
     // Likewise if a ClientProcessConnection was given via Connect(), it
     // provides the ShellClient proxy to use.
@@ skipping 46 matching lines @@
   for (auto it = native_runners_.begin(); it != native_runners_.end(); ++it) {
     if (it->get() == runner) {
       native_runners_.erase(it);
       return;
     }
   }
 }
 
 }  // namespace shell
 }  // namespace mojo