Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 1831603002: Revert of Switch SkBlurImageFilter over to new onFilterImage interface (Closed)

Created:
4 years, 9 months ago by robertphillips
Modified:
4 years, 9 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Switch SkBlurImageFilter over to new onFilterImage interface (patchset #15 id:270001 of https://codereview.chromium.org/1785643003/ ) Reason for revert: serialize-8888 broken for some reason Original issue's description: > Switch SkBlurImageFilter over to new onFilterImage interface > > This CL relies on: > https://codereview.chromium.org/1787883002/ (Add SkSpecialImage::extractSubset & NewFromPixmap) > https://codereview.chromium.org/1808743003/ (Allow SkGpuDevice::drawSprite to handle subset SkBitmaps) > https://codereview.chromium.org/1813813002/ (Add SkSpecialImage::makeTextureImage entry point) > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1785643003 > > Committed: https://skia.googlesource.com/skia/+/3c935bc87020bfd19a08922f7394db3a801d168b TBR=senorblanco@google.com,senorblanco@chromium.org,bsalomon@google.com,reed@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/9c79d7ec4ee43e256f0e34cabcfdce0fea444b64

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -167 lines) Patch
M include/core/SkDevice.h View 2 chunks +5 lines, -6 lines 0 comments Download
M include/effects/SkBlurImageFilter.h View 1 chunk +5 lines, -2 lines 0 comments Download
M src/core/SkCanvas.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M src/core/SkDevice.cpp View 1 chunk +3 lines, -6 lines 0 comments Download
M src/effects/SkBlurImageFilter.cpp View 5 chunks +123 lines, -112 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
robertphillips
Created Revert of Switch SkBlurImageFilter over to new onFilterImage interface
4 years, 9 months ago (2016-03-23 21:03:30 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1831603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1831603002/1
4 years, 9 months ago (2016-03-23 21:03:37 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 21:03:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/9c79d7ec4ee43e256f0e34cabcfdce0fea444b64

Powered by Google App Engine
This is Rietveld 408576698