FR: SAML Sign In - Interstitial page to send users directly to IdP login screen

FR: SAML Sign In - Interstitial page to send users directly to IdP login screen

Depending on the value of the login_authentication_behavior device policy, users
can be given the option to skip the GAIA Minute Maid screen and go directly to
the login screen of the SAML-based enrollment enterprise domain IdP.

Screenshots:
SAML Interstitial Page: https://drive.google.com/open?id=0B6G_-uQnf1_LYlQ2THNuXzlORFk
On Next pressed: https://drive.google.com/open?id=0B6G_-uQnf1_LVm0zaHBYWHg0Tm8
On Signin with different account clicked: https://drive.google.com/open?id=0B6G_-uQnf1_Lc2d3S01kaUQ3Ylk

BUG=498896, 583724
Committed: https://crrev.com/cffafcbc6517076a8b2e0522c628688b5df24b92
Cr-Commit-Position: refs/heads/master@{#383788}

[afakhry, 2016-03-25 22:20:26]

Description was changed from

==========
FR: SAML Sign In - Interstitial page to send users directly to IdP login screen

BUG=498896
==========

to

==========
FR: SAML Sign In - Interstitial page to send users directly to IdP login screen

Depending on the value of the login_authentication_behavior device policy, users
can be given the option to skip the GAIA Minute Maid screen and go directly to
the login screen of the SAML-based enrollment enterprise domain IdP.

Screenshots:
SAML Interstitial Page:
https://drive.google.com/open?id=0B6G_-uQnf1_LYlQ2THNuXzlORFk
On Next pressed: https://drive.google.com/open?id=0B6G_-uQnf1_LVm0zaHBYWHg0Tm8
On Signin with different account clicked:
https://drive.google.com/open?id=0B6G_-uQnf1_Lc2d3S01kaUQ3Ylk

BUG=498896
==========

[afakhry, 2016-03-26 02:48:36]

afakhry@chromium.org changed reviewers:
+ xiyuan@chromium.org

[afakhry, 2016-03-26 02:48:37]

Hi Xiyuan! Could you please review this CL? Thanks!

[xiyuan, 2016-03-28 20:58:41]

Mostly good.

You might want to check out saml_browsertest.cc and add some test cases there,

e.g.
- Test we land on the saml interstitial page when the policy is set;
- Click on "Sign in with a different account" would show Gaia page;
- Add "samlredirect" handling to FakeGaia and test "Next" would redirect to idp;

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/saml_interstitial.html (right):

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/saml_interstitial.html:9: 'domain' - The
interprise domain the device is enrolled to.
nit: interprise -> enterprise

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/saml_interstitial.html:19: <dom-module
name="saml-interstitial" id="saml-interstitial">
"id" attribute should be set in the master dom.

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/saml_interstitial.html:25:
flex-direction: column;
nit: I suspect we could just use "display: block" since we are just a container
of a single gaia-card element.

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/saml_interstitial.html:26: line-height:
150%;
nit: wrong indent

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/saml_interstitial.html:52: <img
id="logoImg" src="chrome://theme/IDR_LOGO_GOOGLE_COLOR_90"
nit: wrong indent

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/saml_interstitial.html:52: <img
id="logoImg" src="chrome://theme/IDR_LOGO_GOOGLE_COLOR_90"
nit: logoImg -> logo-img

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/saml_interstitial.js (right):

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/saml_interstitial.js:6: is:
'saml-interstitial',
nit: insert an empty line between all fields

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/saml_interstitial.js:22:
this.i18n_(['samlInterstitialMessage', this.domain]);
Why not just use loadTimeData here?

i.e.
  this.$.message.content = loadTimeData.getStringF('samlInterstitialMessage',
this.domain);

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/saml_interstitial.js:23:
this.showDomainMessages_ = !!this.domain.length;
|showDomainMessages_| seems redundant. If we do want it, please document it in
html.

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/saml_interstitial.js:26:
this.dispatchEvent(new Event('samlPageNextClicked'));
nit: this.fire('samlPageNextClicked');

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/saml_interstitial.js:29:
this.dispatchEvent(new Event('samlPageChangeAccountClicked'));
nit: this.fire('samlPageChangeAccountClicked');

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/screen_gaia_signin.js (right):

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/screen_gaia_signin.js:247: if
(this.screenMode_ != ScreenMode.SAML_INTERSTITIAL)
nit: seem unnecessary since the event could only be dispatched when screenMode
is ScreenMode.SAML_INTERSTITIAL.

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/screen_gaia_signin.js:255: if
(this.screenMode_ != ScreenMode.SAML_INTERSTITIAL)
nit: ditto

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/screen_gaia_signin.js:266: *
authentication by automatic redirection to the SAML-based enrollment
nit: wrong indent

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/screen_gaia_signin.js:318: 
Should we call this.updateControlsState() since |screenMode_| is relevant to
control states?

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/screen_gaia_signin.js:548:
$('saml-interstitial').domain = data.enterpriseDomain;
nit: Move this into "case ScreenMode.SAML_INTERSTITIAL:" switch case?

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/screen_gaia_signin.js:561:
(this.screenMode_ == ScreenMode.SAML_INTERSTITIAL);
nit: wrong indent?

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/screen_gaia_signin.js:631: if (isSAML &&
this.loading)
Think we should fix this in authenticator.js. That is, if 'ready' is not
dispatched when Authenticator.prototype.onAuthPageLoaded_ is called, dispatch it
there.

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
File chrome/browser/resources/gaia_auth_host/authenticator.js (right):

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/gaia_auth_host/authenticator.js:274: 'client_id=' +
data.clientId + '&access_type=offline');
To be on the safe side, encodeURIComponent(data.clientId)

[afakhry, 2016-03-28 23:01:33]

Description was changed from

==========
FR: SAML Sign In - Interstitial page to send users directly to IdP login screen

Depending on the value of the login_authentication_behavior device policy, users
can be given the option to skip the GAIA Minute Maid screen and go directly to
the login screen of the SAML-based enrollment enterprise domain IdP.

Screenshots:
SAML Interstitial Page:
https://drive.google.com/open?id=0B6G_-uQnf1_LYlQ2THNuXzlORFk
On Next pressed: https://drive.google.com/open?id=0B6G_-uQnf1_LVm0zaHBYWHg0Tm8
On Signin with different account clicked:
https://drive.google.com/open?id=0B6G_-uQnf1_Lc2d3S01kaUQ3Ylk

BUG=498896
==========

to

==========
FR: SAML Sign In - Interstitial page to send users directly to IdP login screen

Depending on the value of the login_authentication_behavior device policy, users
can be given the option to skip the GAIA Minute Maid screen and go directly to
the login screen of the SAML-based enrollment enterprise domain IdP.

Screenshots:
SAML Interstitial Page:
https://drive.google.com/open?id=0B6G_-uQnf1_LYlQ2THNuXzlORFk
On Next pressed: https://drive.google.com/open?id=0B6G_-uQnf1_LVm0zaHBYWHg0Tm8
On Signin with different account clicked:
https://drive.google.com/open?id=0B6G_-uQnf1_Lc2d3S01kaUQ3Ylk

BUG=498896,583724
==========

[afakhry, 2016-03-28 23:15:33]

I will investigate adding the tests in a separate CL as suggested.

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/saml_interstitial.html (right):

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/saml_interstitial.html:9: 'domain' - The
interprise domain the device is enrolled to.
On 2016/03/28 20:58:40, xiyuan wrote:
> nit: interprise -> enterprise

Done.

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/saml_interstitial.html:19: <dom-module
name="saml-interstitial" id="saml-interstitial">
On 2016/03/28 20:58:40, xiyuan wrote:
> "id" attribute should be set in the master dom.

Done.

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/saml_interstitial.html:25:
flex-direction: column;
On 2016/03/28 20:58:40, xiyuan wrote:
> nit: I suspect we could just use "display: block" since we are just a
container
> of a single gaia-card element.

Done.

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/saml_interstitial.html:26: line-height:
150%;
On 2016/03/28 20:58:40, xiyuan wrote:
> nit: wrong indent

Done.

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/saml_interstitial.html:52: <img
id="logoImg" src="chrome://theme/IDR_LOGO_GOOGLE_COLOR_90"
On 2016/03/28 20:58:40, xiyuan wrote:
> nit: wrong indent

Done.

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/saml_interstitial.html:52: <img
id="logoImg" src="chrome://theme/IDR_LOGO_GOOGLE_COLOR_90"
On 2016/03/28 20:58:40, xiyuan wrote:
> nit: logoImg -> logo-img

Done.

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/saml_interstitial.js (right):

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/saml_interstitial.js:6: is:
'saml-interstitial',
On 2016/03/28 20:58:40, xiyuan wrote:
> nit: insert an empty line between all fields

Done.

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/saml_interstitial.js:22:
this.i18n_(['samlInterstitialMessage', this.domain]);
On 2016/03/28 20:58:40, xiyuan wrote:
> Why not just use loadTimeData here?
> 
> i.e.
>   this.$.message.content = loadTimeData.getStringF('samlInterstitialMessage',
> this.domain);

Thanks this is certainly better. I saw an example that does this:
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...
so I thought this is the way.
Done.

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/saml_interstitial.js:23:
this.showDomainMessages_ = !!this.domain.length;
On 2016/03/28 20:58:40, xiyuan wrote:
> |showDomainMessages_| seems redundant. If we do want it, please document it in
> html.

I added a comment to the html.

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/saml_interstitial.js:26:
this.dispatchEvent(new Event('samlPageNextClicked'));
On 2016/03/28 20:58:40, xiyuan wrote:
> nit: this.fire('samlPageNextClicked');

Done.

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/saml_interstitial.js:29:
this.dispatchEvent(new Event('samlPageChangeAccountClicked'));
On 2016/03/28 20:58:40, xiyuan wrote:
> nit: this.fire('samlPageChangeAccountClicked');

Done.

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/screen_gaia_signin.js (right):

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/screen_gaia_signin.js:247: if
(this.screenMode_ != ScreenMode.SAML_INTERSTITIAL)
On 2016/03/28 20:58:40, xiyuan wrote:
> nit: seem unnecessary since the event could only be dispatched when screenMode
> is ScreenMode.SAML_INTERSTITIAL.

I was just being paranoid! :)
Done.

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/screen_gaia_signin.js:255: if
(this.screenMode_ != ScreenMode.SAML_INTERSTITIAL)
On 2016/03/28 20:58:40, xiyuan wrote:
> nit: ditto

Done.

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/screen_gaia_signin.js:266: *
authentication by automatic redirection to the SAML-based enrollment
On 2016/03/28 20:58:40, xiyuan wrote:
> nit: wrong indent

Done.

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/screen_gaia_signin.js:318: 
On 2016/03/28 20:58:40, xiyuan wrote:
> Should we call this.updateControlsState() since |screenMode_| is relevant to
> control states?

Done.

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/screen_gaia_signin.js:548:
$('saml-interstitial').domain = data.enterpriseDomain;
On 2016/03/28 20:58:40, xiyuan wrote:
> nit: Move this into "case ScreenMode.SAML_INTERSTITIAL:" switch case?

Done.

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/screen_gaia_signin.js:561:
(this.screenMode_ == ScreenMode.SAML_INTERSTITIAL);
On 2016/03/28 20:58:40, xiyuan wrote:
> nit: wrong indent?

Done.

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/screen_gaia_signin.js:631: if (isSAML &&
this.loading)
On 2016/03/28 20:58:40, xiyuan wrote:
> Think we should fix this in authenticator.js. That is, if 'ready' is not
> dispatched when Authenticator.prototype.onAuthPageLoaded_ is called, dispatch
it
> there.

Done.

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
File chrome/browser/resources/gaia_auth_host/authenticator.js (right):

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/gaia_auth_host/authenticator.js:274: 'client_id=' +
data.clientId + '&access_type=offline');
On 2016/03/28 20:58:40, xiyuan wrote:
> To be on the safe side, encodeURIComponent(data.clientId)

Done.

[xiyuan, 2016-03-29 02:10:50]

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/saml_interstitial.js (right):

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/saml_interstitial.js:22:
this.i18n_(['samlInterstitialMessage', this.domain]);
On 2016/03/28 23:15:32, afakhry wrote:
> On 2016/03/28 20:58:40, xiyuan wrote:
> > Why not just use loadTimeData here?
> > 
> > i.e.
> >   this.$.message.content =
loadTimeData.getStringF('samlInterstitialMessage',
> > this.domain);
> 
> Thanks this is certainly better. I saw an example that does this:
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res...
> so I thought this is the way.
> Done.

I suspect the sample does it that way because of its content is provided as
polymer binding. But we do it in plain js so should be good to just use the old
way.

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/screen_gaia_signin.js (right):

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/screen_gaia_signin.js:266: *
authentication by automatic redirection to the SAML-based enrollment
On 2016/03/28 23:15:32, afakhry wrote:
> On 2016/03/28 20:58:40, xiyuan wrote:
> > nit: wrong indent
> 
> Done.

What you did in new patch is fine but I meant to indent 4 spaces on 2nd line, :)


i.e.

  * @param {boolean} doSamlRedirect If the authenticator should do
  *     authentication by automatic redirection to the SAML-based

https://codereview.chromium.org/1831523003/diff/100001/chrome/browser/resourc...
File chrome/browser/resources/chromeos/login/saml_interstitial.html (right):

https://codereview.chromium.org/1831523003/diff/100001/chrome/browser/resourc...
chrome/browser/resources/chromeos/login/saml_interstitial.html:10:
'showDomainMessages_' - If true, the messages showing the enrollment domain
Remove trailing "_"?

https://codereview.chromium.org/1831523003/diff/100001/chrome/browser/resourc...
File chrome/browser/resources/gaia_auth_host/authenticator.js (right):

https://codereview.chromium.org/1831523003/diff/100001/chrome/browser/resourc...
chrome/browser/resources/gaia_auth_host/authenticator.js:705: }
nit: Can we make this a method, e.g. fireReadyEvent, and call it here and  in
onContentLoad_?

https://codereview.chromium.org/1831523003/diff/100001/chrome/browser/resourc...
chrome/browser/resources/gaia_auth_host/authenticator.js:790: this.readyFired_ =
false;
Good catch. Move this to clearCredentials_, which is called on every
load/reload. (If you want, you can give it a better name, e.g. resetStates or
something :))

https://codereview.chromium.org/1831523003/diff/100001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/TestExpectations (left):

https://codereview.chromium.org/1831523003/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/TestExpectations:369: crbug.com/591199
fast/repaint/repaint-during-scroll-with-zoom.html [ NeedsRebaseline ]
Seems unrelated?

[afakhry, 2016-03-29 03:12:02]

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
File chrome/browser/resources/chromeos/login/screen_gaia_signin.js (right):

https://codereview.chromium.org/1831523003/diff/80001/chrome/browser/resource...
chrome/browser/resources/chromeos/login/screen_gaia_signin.js:266: *
authentication by automatic redirection to the SAML-based enrollment
On 2016/03/29 02:10:49, xiyuan wrote:
> On 2016/03/28 23:15:32, afakhry wrote:
> > On 2016/03/28 20:58:40, xiyuan wrote:
> > > nit: wrong indent
> > 
> > Done.
> 
> What you did in new patch is fine but I meant to indent 4 spaces on 2nd line,
:)
> 
> 
> i.e.
> 
>   * @param {boolean} doSamlRedirect If the authenticator should do
>   *     authentication by automatic redirection to the SAML-based

Done.

https://codereview.chromium.org/1831523003/diff/100001/chrome/browser/resourc...
File chrome/browser/resources/chromeos/login/saml_interstitial.html (right):

https://codereview.chromium.org/1831523003/diff/100001/chrome/browser/resourc...
chrome/browser/resources/chromeos/login/saml_interstitial.html:10:
'showDomainMessages_' - If true, the messages showing the enrollment domain
On 2016/03/29 02:10:49, xiyuan wrote:
> Remove trailing "_"?

Done.

https://codereview.chromium.org/1831523003/diff/100001/chrome/browser/resourc...
File chrome/browser/resources/gaia_auth_host/authenticator.js (right):

https://codereview.chromium.org/1831523003/diff/100001/chrome/browser/resourc...
chrome/browser/resources/gaia_auth_host/authenticator.js:705: }
On 2016/03/29 02:10:49, xiyuan wrote:
> nit: Can we make this a method, e.g. fireReadyEvent, and call it here and  in
> onContentLoad_?

Done.

https://codereview.chromium.org/1831523003/diff/100001/chrome/browser/resourc...
chrome/browser/resources/gaia_auth_host/authenticator.js:790: this.readyFired_ =
false;
On 2016/03/29 02:10:49, xiyuan wrote:
> Good catch. Move this to clearCredentials_, which is called on every
> load/reload. (If you want, you can give it a better name, e.g. resetStates or
> something :))

Done. But just to make sure, you meant to remove it from here altogether,
correct?

https://codereview.chromium.org/1831523003/diff/100001/third_party/WebKit/Lay...
File third_party/WebKit/LayoutTests/TestExpectations (left):

https://codereview.chromium.org/1831523003/diff/100001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/TestExpectations:369: crbug.com/591199
fast/repaint/repaint-during-scroll-with-zoom.html [ NeedsRebaseline ]
On 2016/03/29 02:10:49, xiyuan wrote:
> Seems unrelated?

Not sure how this ended up here! Let me see.

[xiyuan, 2016-03-29 15:55:50]

lgtm

[afakhry, 2016-03-29 17:35:32]

The CQ bit was checked by afakhry@chromium.org

[commit-bot: I haz the power, 2016-03-29 17:35:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1831523003/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1831523003/140001

[commit-bot: I haz the power, 2016-03-29 17:46:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-29 17:46:27]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[afakhry, 2016-03-29 17:56:09]

The CQ bit was checked by afakhry@chromium.org

[afakhry, 2016-03-29 17:56:09]

The patchset sent to the CQ was uploaded after l-g-t-m from xiyuan@chromium.org
Link to the patchset: https://codereview.chromium.org/1831523003/#ps160001
(title: "remove the <br> comment")

[commit-bot: I haz the power, 2016-03-29 17:56:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1831523003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1831523003/160001

[commit-bot: I haz the power, 2016-03-29 19:07:21]

Description was changed from

==========
FR: SAML Sign In - Interstitial page to send users directly to IdP login screen

Depending on the value of the login_authentication_behavior device policy, users
can be given the option to skip the GAIA Minute Maid screen and go directly to
the login screen of the SAML-based enrollment enterprise domain IdP.

Screenshots:
SAML Interstitial Page:
https://drive.google.com/open?id=0B6G_-uQnf1_LYlQ2THNuXzlORFk
On Next pressed: https://drive.google.com/open?id=0B6G_-uQnf1_LVm0zaHBYWHg0Tm8
On Signin with different account clicked:
https://drive.google.com/open?id=0B6G_-uQnf1_Lc2d3S01kaUQ3Ylk

BUG=498896,583724
==========

to

==========
FR: SAML Sign In - Interstitial page to send users directly to IdP login screen

Depending on the value of the login_authentication_behavior device policy, users
can be given the option to skip the GAIA Minute Maid screen and go directly to
the login screen of the SAML-based enrollment enterprise domain IdP.

Screenshots:
SAML Interstitial Page:
https://drive.google.com/open?id=0B6G_-uQnf1_LYlQ2THNuXzlORFk
On Next pressed: https://drive.google.com/open?id=0B6G_-uQnf1_LVm0zaHBYWHg0Tm8
On Signin with different account clicked:
https://drive.google.com/open?id=0B6G_-uQnf1_Lc2d3S01kaUQ3Ylk

BUG=498896,583724
==========

[commit-bot: I haz the power, 2016-03-29 19:07:22]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-03-29 19:08:57]

Description was changed from

==========
FR: SAML Sign In - Interstitial page to send users directly to IdP login screen

Depending on the value of the login_authentication_behavior device policy, users
can be given the option to skip the GAIA Minute Maid screen and go directly to
the login screen of the SAML-based enrollment enterprise domain IdP.

Screenshots:
SAML Interstitial Page:
https://drive.google.com/open?id=0B6G_-uQnf1_LYlQ2THNuXzlORFk
On Next pressed: https://drive.google.com/open?id=0B6G_-uQnf1_LVm0zaHBYWHg0Tm8
On Signin with different account clicked:
https://drive.google.com/open?id=0B6G_-uQnf1_Lc2d3S01kaUQ3Ylk

BUG=498896,583724
==========

to

==========
FR: SAML Sign In - Interstitial page to send users directly to IdP login screen

Depending on the value of the login_authentication_behavior device policy, users
can be given the option to skip the GAIA Minute Maid screen and go directly to
the login screen of the SAML-based enrollment enterprise domain IdP.

Screenshots:
SAML Interstitial Page:
https://drive.google.com/open?id=0B6G_-uQnf1_LYlQ2THNuXzlORFk
On Next pressed: https://drive.google.com/open?id=0B6G_-uQnf1_LVm0zaHBYWHg0Tm8
On Signin with different account clicked:
https://drive.google.com/open?id=0B6G_-uQnf1_Lc2d3S01kaUQ3Ylk

BUG=498896,583724

Committed: https://crrev.com/cffafcbc6517076a8b2e0522c628688b5df24b92
Cr-Commit-Position: refs/heads/master@{#383788}
==========

[commit-bot: I haz the power, 2016-03-29 19:08:59]

Patchset 9 (id:??) landed as
https://crrev.com/cffafcbc6517076a8b2e0522c628688b5df24b92
Cr-Commit-Position: refs/heads/master@{#383788}