chrome/browser/resources/chromeos/login/saml_interstitial.html - Issue 1831523003: FR: SAML Sign In - Interstitial page to send users directly to IdP login screen

Side by Side Diff: chrome/browser/resources/chromeos/login/saml_interstitial.html

Issue 1831523003: FR: SAML Sign In - Interstitial page to send users directly to IdP login screen (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix failing tests Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/login/offline_gaia.js ('k') | chrome/browser/resources/chromeos/login/saml_interstitial.js » ('j') | chrome/browser/resources/chromeos/login/saml_interstitial.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">

	2

	3 <!--

	4 UI for the SAML interstitial page.

	5 Example:

	6 <saml-interstitial></saml-interstitial>

	7

	8 Attributes:

	9 'domain' - The interprise domain the device is enrolled to.
	xiyuan 2016/03/28 20:58:40 nit: interprise -> enterprise nit: interprise -> enterprise afakhry 2016/03/28 23:15:32 Done. Show quoted text On 2016/03/28 20:58:40, xiyuan wrote: > nit: interprise -> enterprise Done.
	10

	11 Events:

	12 'samlPageNextClicked' - Fired when the "Next" button is clicked indicating

	13 that the user would like to proceed with

	14 authentication via his enrollement SAML IdP.

	15 'samlPageChangeAccountClicked' - Fired when the user clicks the sign in with

	16 a differnt account link. GAIA Minute Maid

	17 screen will be shown.

	18 -->

	19 <dom-module name="saml-interstitial" id="saml-interstitial">
	xiyuan 2016/03/28 20:58:40 "id" attribute should be set in the master dom. "id" attribute should be set in the master dom. afakhry 2016/03/28 23:15:32 Done. Show quoted text On 2016/03/28 20:58:40, xiyuan wrote: > "id" attribute should be set in the master dom. Done.
	20

	21 <template>

	22 <style>

	23 :host {

	24 display: flex;

	25 flex-direction: column;
	xiyuan 2016/03/28 20:58:40 nit: I suspect we could just use "display: block" nit: I suspect we could just use "display: block" since we are just a container of a single gaia-card element. afakhry 2016/03/28 23:15:32 Done. Show quoted text On 2016/03/28 20:58:40, xiyuan wrote: > nit: I suspect we could just use "display: block" since we are just a container > of a single gaia-card element. Done.
	26 line-height: 150%;
	xiyuan 2016/03/28 20:58:40 nit: wrong indent nit: wrong indent afakhry 2016/03/28 23:15:32 Done. Show quoted text On 2016/03/28 20:58:40, xiyuan wrote: > nit: wrong indent Done.
	27 }

	28 </style>

	29

	30 <gaia-card id="samlInterstitialCard" class="fit">

	31 <div id="samlInterstitialHeader"

	32 class="header flex vertical layout end-justified start">

	33 <h1 class="welcome-message" i18n-content="loginWelcomeMessage">

	34 </h1>

	35 <p id="managedBy" class="enterprise-info"

	36 i18n-content="enterpriseInfoMessage"

	37 hidden$="[[!showDomainMessages_]]">

	38 </p>

	39 </div>

	40

	41 <div class="footer flex vertical layout justified">

	42 <!-- This message contains <strong> and <br> tags inside. -->

	43 <html-echo id="message" hidden$="[[!showDomainMessages_]]"></html-echo>

	44

	45 <gaia-input-form on-submit="onSamlPageNextClicked_"

	46 i18n-values="button-text:samlInterstitialNextBtn">

	47 <gaia-button type="link" on-tap="onSamlPageChangeAccountClicked_"

	48 i18n-content="samlInterstitialChangeAccountLink">

	49 </gaia-button>

	50 </gaia-input-form>

	51

	52 <img id="logoImg" src="chrome://theme/IDR_LOGO_GOOGLE_COLOR_90"
	xiyuan 2016/03/28 20:58:40 nit: wrong indent nit: wrong indent xiyuan 2016/03/28 20:58:40 nit: logoImg -> logo-img nit: logoImg -> logo-img afakhry 2016/03/28 23:15:32 Done. Show quoted text On 2016/03/28 20:58:40, xiyuan wrote: > nit: wrong indent Done. afakhry 2016/03/28 23:15:32 Done. Show quoted text On 2016/03/28 20:58:40, xiyuan wrote: > nit: logoImg -> logo-img Done.
	53 class="self-center" alt="">

	54 </div>

	55 </gaia-card>

	56

	57 </template>

	58

	59 </dom-module>

OLD	NEW