Audit test code callsites that need an explicit lifecycle update.

Audit test code callsites that need an explicit lifecycle update.

1) Introduce WebFrameContentDumper::dumpWebViewAsText, which explicitly
forces a lifecycle update, and change all test code that relied on
WebFrameContentDumper:dumpFrameTreeAsText to use it instead.

2) Rename WebFrameContentDumper::dumpFrameTreeAsText to
WebFrameContentDumper::deprecatedDumpFrameTreeAsText.

This is a meek step toward re-re-relanding https://codereview.chromium.org/1740173003,
which only includes adding explicit lifecycle updates in places where
they will become necessary, once TextIteratorAlgorithm doesn't
force the layout update in its constructor.

R=esprehn
BUG=590295
Committed: https://crrev.com/232042e500104e908e2a1e40305130d480a11cae
Cr-Commit-Position: refs/heads/master@{#385187}

[dglazkov, 2016-03-25 23:09:56]

The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-25 23:10:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1831423003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1831423003/1

[commit-bot: I haz the power, 2016-03-26 00:18:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-26 00:18:23]

Dry run: This issue passed the CQ dry run.

[esprehn, 2016-03-26 00:32:15]

Why not make dumpFrameTreeAsText do it as the first line? Seems like it should?

[dglazkov, 2016-03-26 03:05:37]

On 2016/03/26 at 00:32:15, esprehn wrote:
> Why not make dumpFrameTreeAsText do it as the first line? Seems like it
should?

It really should, except I am still using this function for grabbing the text in
translate. When I fix http://crbug.com/585164, I can definitely do that.

[dglazkov, 2016-04-03 04:17:15]

The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run

[dglazkov, 2016-04-03 04:17:18]

Changed to use two explicit methods.

[commit-bot: I haz the power, 2016-04-03 04:17:23]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1831423003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1831423003/20001

[commit-bot: I haz the power, 2016-04-03 06:15:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-03 06:15:44]

Dry run: This issue passed the CQ dry run.

[dglazkov, 2016-04-03 15:27:05]

The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-03 15:27:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1831423003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1831423003/40001

[dglazkov, 2016-04-03 15:37:29]

Description was changed from

==========
Audit test code callsites that need an explicit lifecycle update.

This is a meek step toward re-re-relanding
https://codereview.chromium.org/1740173003,
which only includes adding explicit lifecycle updates in places where
they will become necessary, once TextIteratorAlgorithm doesn't
force the layout update in its constructor.

R=esprehn
BUG=590295
==========

to

==========
Audit test code callsites that need an explicit lifecycle update.

1) Introduce WebFrameContentDumper::dumpWebViewAsText, which explicitly
forces a lifecycle update, and change all test code that relied on
WebFrameContentDumper:dumpFrameTreeAsText to use it instead.

2) Rename WebFrameContentDumper::dumpFrameTreeAsText to
WebFrameContentDumper::deprecatedDumpFrameTreeAsText.

This is a meek step toward re-re-relanding
https://codereview.chromium.org/1740173003,
which only includes adding explicit lifecycle updates in places where
they will become necessary, once TextIteratorAlgorithm doesn't
force the layout update in its constructor.

R=esprehn
BUG=590295
==========

[dglazkov, 2016-04-03 15:37:47]

esprehn, PTAL. I made it BETTER.

[commit-bot: I haz the power, 2016-04-03 16:56:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-03 16:56:28]

Dry run: This issue passed the CQ dry run.

[esprehn, 2016-04-04 21:54:41]

lgtm, okay lets start here. I think we want this all enforced with asserts
though, if you don't want the DidMeaningfulLayout path to force layouts, you
should have a CHECK(nothingIsDirty()) check in there.

[dglazkov, 2016-04-05 15:14:06]

The CQ bit was checked by dglazkov@chromium.org

[commit-bot: I haz the power, 2016-04-05 15:14:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1831423003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1831423003/40001

[dglazkov, 2016-04-05 15:14:22]

On 2016/04/04 at 21:54:41, esprehn wrote:
> lgtm, okay lets start here. I think we want this all enforced with asserts
though, if you don't want the DidMeaningfulLayout path to force layouts, you
should have a CHECK(nothingIsDirty()) check in there.

Will do!

[commit-bot: I haz the power, 2016-04-05 15:22:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 15:22:38]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jochen (gone - plz use gerrit), 2016-04-05 15:24:18]

jochen@chromium.org changed reviewers:
+ jochen@chromium.org

[jochen (gone - plz use gerrit), 2016-04-05 15:24:19]

lgtm

[dglazkov, 2016-04-05 15:25:04]

The CQ bit was checked by dglazkov@chromium.org

[commit-bot: I haz the power, 2016-04-05 15:25:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1831423003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1831423003/40001

[commit-bot: I haz the power, 2016-04-05 16:24:50]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-05 16:27:02]

Description was changed from

==========
Audit test code callsites that need an explicit lifecycle update.

1) Introduce WebFrameContentDumper::dumpWebViewAsText, which explicitly
forces a lifecycle update, and change all test code that relied on
WebFrameContentDumper:dumpFrameTreeAsText to use it instead.

2) Rename WebFrameContentDumper::dumpFrameTreeAsText to
WebFrameContentDumper::deprecatedDumpFrameTreeAsText.

This is a meek step toward re-re-relanding
https://codereview.chromium.org/1740173003,
which only includes adding explicit lifecycle updates in places where
they will become necessary, once TextIteratorAlgorithm doesn't
force the layout update in its constructor.

R=esprehn
BUG=590295
==========

to

==========
Audit test code callsites that need an explicit lifecycle update.

1) Introduce WebFrameContentDumper::dumpWebViewAsText, which explicitly
forces a lifecycle update, and change all test code that relied on
WebFrameContentDumper:dumpFrameTreeAsText to use it instead.

2) Rename WebFrameContentDumper::dumpFrameTreeAsText to
WebFrameContentDumper::deprecatedDumpFrameTreeAsText.

This is a meek step toward re-re-relanding
https://codereview.chromium.org/1740173003,
which only includes adding explicit lifecycle updates in places where
they will become necessary, once TextIteratorAlgorithm doesn't
force the layout update in its constructor.

R=esprehn
BUG=590295

Committed: https://crrev.com/232042e500104e908e2a1e40305130d480a11cae
Cr-Commit-Position: refs/heads/master@{#385187}
==========

[commit-bot: I haz the power, 2016-04-05 16:27:05]

Patchset 3 (id:??) landed as
https://crrev.com/232042e500104e908e2a1e40305130d480a11cae
Cr-Commit-Position: refs/heads/master@{#385187}