Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(322)

Unified Diff: third_party/WebKit/public/web/WebFrameContentDumper.h

Issue 1831423003: Audit test code callsites that need an explicit lifecycle update. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clean up. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/web/tests/WebViewTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/web/WebFrameContentDumper.h
diff --git a/third_party/WebKit/public/web/WebFrameContentDumper.h b/third_party/WebKit/public/web/WebFrameContentDumper.h
index a1e3f65b7d411da024944873571cefa5f7cd4f61..76ee433dd73679909533884eca0e3c3b42f1fbbb 100644
--- a/third_party/WebKit/public/web/WebFrameContentDumper.h
+++ b/third_party/WebKit/public/web/WebFrameContentDumper.h
@@ -10,6 +10,7 @@
namespace blink {
class WebLocalFrame;
+class WebView;
class WebString;
// Functions in this class should only be used for
@@ -27,14 +28,20 @@ public:
typedef unsigned LayoutAsTextControls;
// Returns the contents of this frame as a string. If the text is
- // longer than maxChars, it will be clipped to that length. WARNING:
- // This function may be slow depending on the number of characters
- // retrieved and page complexity. For a typically sized page, expect
- // it to take on the order of milliseconds.
+ // longer than maxChars, it will be clipped to that length.
//
// If there is room, subframe text will be recursively appended. Each
// frame will be separated by an empty line.
- BLINK_EXPORT static WebString dumpFrameTreeAsText(WebLocalFrame*, size_t maxChars);
+ // TODO(dglazkov): WebFrameContentDumper should only be used for
+ // testing purposes and this function is being deprecated.
+ // Don't add new callsites, please.
+ // See http://crbug.com/585164 for details.
+ BLINK_EXPORT static WebString deprecatedDumpFrameTreeAsText(WebLocalFrame*, size_t maxChars);
+
+ // Dumps the contents of of a WebView as text, starting from the main
+ // frame and recursively appending every subframe, separated by an
+ // empty line.
+ BLINK_EXPORT static WebString dumpWebViewAsText(WebView*, size_t maxChars);
// Returns HTML text for the contents of this frame, generated
// from the DOM.
« no previous file with comments | « third_party/WebKit/Source/web/tests/WebViewTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698