Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1831263002: Remove unused params of CPDF_Image::SetImage. (Closed)

Created:
4 years, 9 months ago by dsinclair
Modified:
4 years, 9 months ago
Reviewers:
Tom Sepez
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove unused params of CPDF_Image::SetImage. The last 3 params of CPDF_Image::SetImage are unused, remove and cleanup logic. BUG=pdfium:194 Committed: https://pdfium.googlesource.com/pdfium/+/65ea3949de6536b1c122eadb4ac7828323fbc408

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -57 lines) Patch
M core/fpdfapi/fpdf_page/cpdf_image.cpp View 1 6 chunks +13 lines, -52 lines 0 comments Download
M core/fpdfapi/fpdf_page/include/cpdf_image.h View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dsinclair
PTAL. Removed the 4th param when shuffling the files around, this removes the other 3.
4 years, 9 months ago (2016-03-25 03:41:50 UTC) #2
Tom Sepez
lgtm
4 years, 9 months ago (2016-03-25 15:46:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1831263002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1831263002/20001
4 years, 9 months ago (2016-03-25 15:56:36 UTC) #5
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 16:16:37 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/65ea3949de6536b1c122eadb4ac7828323fb...

Powered by Google App Engine
This is Rietveld 408576698