Remove unused params of CPDF_Image::SetImage.

core/fpdfapi/fpdf_page/cpdf_image.cpp

 // Copyright 2016 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/fpdfapi/fpdf_page/include/cpdf_image.h"
 
 #include "core/fpdfapi/fpdf_parser/include/cpdf_document.h"
 #include "core/fpdfapi/include/cpdf_modulemgr.h"
@@ skipping 135 matching lines @@
     pFile->ReadBlock(pData, 0, size);
     pDict = InitJPEG(pData, size);
     FX_Free(pData);
   }
   if (!pDict) {
     return;
   }
   m_pStream->InitStreamFromFile(pFile, pDict);
 }
 
-void CPDF_Image::SetImage(const CFX_DIBitmap* pBitmap,
-                          int32_t iCompress,
-                          IFX_FileWrite* pFileWrite,
-                          IFX_FileRead* pFileRead,
-                          const CFX_DIBitmap* pMask) {
+void CPDF_Image::SetImage(const CFX_DIBitmap* pBitmap, int32_t iCompress) {
   int32_t BitmapWidth = pBitmap->GetWidth();
   int32_t BitmapHeight = pBitmap->GetHeight();
   if (BitmapWidth < 1 || BitmapHeight < 1) {
     return;
   }
   uint8_t* src_buf = pBitmap->GetBuffer();
   int32_t src_pitch = pBitmap->GetPitch();
   int32_t bpp = pBitmap->GetBPP();
 
   CPDF_Dictionary* pDict = new CPDF_Dictionary;
@@ skipping 84 matching lines @@
     } else {
       opType = 0;
     }
   }
   const CFX_DIBitmap* pMaskBitmap = NULL;
   FX_BOOL bDeleteMask = FALSE;
   if (pBitmap->HasAlpha()) {
     pMaskBitmap = pBitmap->GetAlphaMask();
     bDeleteMask = TRUE;
   }
-  if (!pMaskBitmap && pMask) {
-    FXDIB_Format maskFormat = pMask->GetFormat();
-    if (maskFormat == FXDIB_1bppMask || maskFormat == FXDIB_8bppMask) {
-      pMaskBitmap = pMask;
-    }
-  }
   if (pMaskBitmap) {
     int32_t maskWidth = pMaskBitmap->GetWidth();
     int32_t maskHeight = pMaskBitmap->GetHeight();
     uint8_t* mask_buf = NULL;
     FX_STRSIZE mask_size = 0;
     CPDF_Dictionary* pMaskDict = new CPDF_Dictionary;
     pMaskDict->SetAtName("Type", "XObject");
     pMaskDict->SetAtName("Subtype", "Image");
     pMaskDict->SetAtInteger("Width", maskWidth);
     pMaskDict->SetAtInteger("Height", maskHeight);
@@ skipping 12 matching lines @@
     }
     pMaskDict->SetAtInteger("Length", mask_size);
 
     CPDF_Stream* pMaskStream = new CPDF_Stream(mask_buf, mask_size, pMaskDict);
     m_pDocument->AddIndirectObject(pMaskStream);
     pDict->SetAtReference("SMask", m_pDocument, pMaskStream);
     if (bDeleteMask) {
       delete pMaskBitmap;
     }
   }
-  FX_BOOL bStream = pFileWrite && pFileRead;
   if (opType == 0) {
     if (iCompress & PDF_IMAGE_LOSSLESS_COMPRESS) {
     } else {
       if (pBitmap->GetBPP() == 1) {
       } else if (pBitmap->GetBPP() >= 8 && pBitmap->GetPalette()) {
         CFX_DIBitmap* pNewBitmap = new CFX_DIBitmap();
         pNewBitmap->Copy(pBitmap);
         pNewBitmap->ConvertFormat(FXDIB_Rgb);
-        SetImage(pNewBitmap, iCompress, pFileWrite, pFileRead);
+        SetImage(pNewBitmap, iCompress);
         if (pDict) {
           pDict->Release();
           pDict = NULL;
         }
         FX_Free(dest_buf);
         dest_buf = NULL;
         dest_size = 0;
         delete pNewBitmap;
         return;
       }
     }
-    if (bStream) {
-      pFileWrite->WriteBlock(dest_buf, dest_size);
-      FX_Free(dest_buf);
-      dest_buf = NULL;
-    }
   } else if (opType == 1) {
-    if (!bStream) {
-      dest_buf = FX_Alloc2D(uint8_t, dest_pitch, BitmapHeight);
-      dest_size =
-          dest_pitch * BitmapHeight;  // Safe since checked alloc returned.
-    }
+    dest_buf = FX_Alloc2D(uint8_t, dest_pitch, BitmapHeight);
+    dest_size = dest_pitch * BitmapHeight;  // Safe as checked alloc returned.
+
     uint8_t* pDest = dest_buf;
     for (int32_t i = 0; i < BitmapHeight; i++) {
-      if (!bStream) {
-        FXSYS_memcpy(pDest, src_buf, dest_pitch);
-        pDest += dest_pitch;
-      } else {
-        pFileWrite->WriteBlock(src_buf, dest_pitch);
-      }
+      FXSYS_memcpy(pDest, src_buf, dest_pitch);
+      pDest += dest_pitch;
       src_buf += src_pitch;
     }
   } else if (opType == 2) {
-    if (!bStream) {
-      dest_buf = FX_Alloc2D(uint8_t, dest_pitch, BitmapHeight);
-      dest_size =
-          dest_pitch * BitmapHeight;  // Safe since checked alloc returned.
-    } else {
-      dest_buf = FX_Alloc(uint8_t, dest_pitch);
-    }
+    dest_buf = FX_Alloc2D(uint8_t, dest_pitch, BitmapHeight);
+    dest_size = dest_pitch * BitmapHeight;  // Safe as checked alloc returned.
+
     uint8_t* pDest = dest_buf;
     int32_t src_offset = 0;
     int32_t dest_offset = 0;
     for (int32_t row = 0; row < BitmapHeight; row++) {
       src_offset = row * src_pitch;
       for (int32_t column = 0; column < BitmapWidth; column++) {
         FX_FLOAT alpha = 1;
         pDest[dest_offset] = (uint8_t)(src_buf[src_offset + 2] * alpha);
         pDest[dest_offset + 1] = (uint8_t)(src_buf[src_offset + 1] * alpha);
         pDest[dest_offset + 2] = (uint8_t)(src_buf[src_offset] * alpha);
         dest_offset += 3;
         src_offset += bpp == 24 ? 3 : 4;
       }
-      if (bStream) {
-        pFileWrite->WriteBlock(pDest, dest_pitch);
-        pDest = dest_buf;
-      } else {
-        pDest += dest_pitch;
-      }
+
+      pDest += dest_pitch;
       dest_offset = 0;
     }
-    if (bStream) {
-      FX_Free(dest_buf);
-      dest_buf = NULL;
-    }
   }
   if (!m_pStream) {
     m_pStream = new CPDF_Stream(NULL, 0, NULL);
   }
-  if (!bStream) {
-    m_pStream->InitStream(dest_buf, dest_size, pDict);
-  } else {
-    pFileWrite->Flush();
-    m_pStream->InitStreamFromFile(pFileRead, pDict);
-  }
+  m_pStream->InitStream(dest_buf, dest_size, pDict);
   m_bIsMask = pBitmap->IsAlphaMask();
   m_Width = BitmapWidth;
   m_Height = BitmapHeight;
   FX_Free(dest_buf);
 }
 
 void CPDF_Image::ResetCache(CPDF_Page* pPage, const CFX_DIBitmap* pBitmap) {
   pPage->GetRenderCache()->ResetBitmap(m_pStream, pBitmap);
 }
 
@@ skipping 54 matching lines @@
   }
   if (!ret) {
     delete m_pDIBSource;
     m_pDIBSource = nullptr;
     return FALSE;
   }
   m_pMask = pSource->DetachMask();
   m_MatteColor = pSource->GetMatteColor();
   return FALSE;
 }