Issue 1831103003: media : Return after rejecting promise in MediaDrmBridge

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1831103003: media : Return after rejecting promise in MediaDrmBridge (Closed)

Created:
4 years, 9 months ago by xhwang

Modified:
4 years, 9 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2661

Target Ref:
refs/pending/branch-heads/2661

Project:
chromium

Visibility:
Public.

media : Return after rejecting promise in MediaDrmBridge This fixes a bug where we continue to call Java after rejecting a promise, which could trigger rejecting the same promise again. BUG=597514 TEST=No double promise rejection in manual testing. Review URL: https://codereview.chromium.org/1823413003 Cr-Commit-Position: refs/heads/master@{#383110} (cherry picked from commit 950d2d3ba6e0aee4bbae0c67eb6c77feaae55314) Committed: https://chromium.googlesource.com/chromium/src/+/50b099e47e84590ab95d880658ac6f2fee9b2a44

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	media/base/android/media_drm_bridge.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

xhwang

4 years, 9 months ago (2016-03-24 20:39:48 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
50b099e47e84590ab95d880658ac6f2fee9b2a44.