Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1823413003: media : Return after rejecting promise in MediaDrmBridge (Closed)

Created:
4 years, 9 months ago by xhwang
Modified:
4 years, 9 months ago
Reviewers:
ddorwin
CC:
chromium-reviews, posciak+watch_chromium.org, feature-media-reviews_chromium.org, avayvod+watch_chromium.org, mcasas+watch_chromium.org, mlamouri+watch-media_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media : Return after rejecting promise in MediaDrmBridge This fixes a bug where we continue to call Java after rejecting a promise, which could trigger rejecting the same promise again. BUG=597514 TEST=No double promise rejection in manual testing. Committed: https://crrev.com/950d2d3ba6e0aee4bbae0c67eb6c77feaae55314 Cr-Commit-Position: refs/heads/master@{#383110}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M media/base/android/media_drm_bridge.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
xhwang
PTAL
4 years, 9 months ago (2016-03-24 06:12:21 UTC) #2
xhwang
More details: This bug wasn't exposed because in most cases the initdata is valid so ...
4 years, 9 months ago (2016-03-24 06:26:45 UTC) #3
ddorwin
lgtm
4 years, 9 months ago (2016-03-24 16:43:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1823413003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1823413003/1
4 years, 9 months ago (2016-03-24 16:45:07 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-24 18:57:14 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 18:58:50 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/950d2d3ba6e0aee4bbae0c67eb6c77feaae55314
Cr-Commit-Position: refs/heads/master@{#383110}

Powered by Google App Engine
This is Rietveld 408576698