Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Unified Diff: Source/core/css/resolver/StyleResolver.cpp

Issue 18311002: Partial implementation of CSSVariablesMap for CSS Variables CSSOM (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebased webexposed tests Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/resolver/StyleResolver.cpp
diff --git a/Source/core/css/resolver/StyleResolver.cpp b/Source/core/css/resolver/StyleResolver.cpp
index c72643e50dc939b355312672aab8077f2b6b0d7e..6e0b0c2f34971629b3e82c4ca65c7969d0603bfb 100644
--- a/Source/core/css/resolver/StyleResolver.cpp
+++ b/Source/core/css/resolver/StyleResolver.cpp
@@ -2334,10 +2334,13 @@ void StyleResolver::resolveVariables(CSSPropertyID id, CSSValue* value, Vector<s
for (unsigned i = 0; i < resultSet->propertyCount(); i++) {
StylePropertySet::PropertyReference property = resultSet->propertyAt(i);
- if (property.id() != CSSPropertyVariable && hasVariableReference(property.value()))
+ if (property.id() != CSSPropertyVariable && hasVariableReference(property.value())) {
resolveVariables(property.id(), property.value(), knownExpressions);
- else
+ } else {
applyProperty(property.id(), property.value());
+ // All properties become dependent their parent style when they use variables.
+ m_state.style()->setHasExplicitlyInheritedProperties();
esprehn 2013/07/04 02:48:52 This doesn't seem related to the patch?
alancutter (OOO until 2018) 2013/07/04 06:18:14 This fixes a bug which is only observable when CSS
+ }
}
}
« Source/core/css/StylePropertySet.cpp ('K') | « Source/core/css/StylePropertySet.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698