Partial implementation of CSSVariablesMap for CSS Variables CSSOM

Source/core/css/resolver/StyleResolver.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
  * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
  * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
  * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
  * Copyright (C) Research In Motion Limited 2011. All rights reserved.
@@ skipping 2316 matching lines @@
 
     knownExpressions.append(expression);
 
     // FIXME: It would be faster not to re-parse from strings, but for now CSS property validation lives inside the parser so we do it there.
     RefPtr<MutableStylePropertySet> resultSet = MutableStylePropertySet::create();
     if (!CSSParser::parseValue(resultSet.get(), id, expression.second, false, document()))
         return; // expression failed to parse.
 
     for (unsigned i = 0; i < resultSet->propertyCount(); i++) {
         StylePropertySet::PropertyReference property = resultSet->propertyAt(i);
-        if (property.id() != CSSPropertyVariable && hasVariableReference(property.value()))
+        if (property.id() != CSSPropertyVariable && hasVariableReference(property.value())) {
             resolveVariables(property.id(), property.value(), knownExpressions);
-        else
+        } else {
             applyProperty(property.id(), property.value());
+            // All properties become dependent their parent style when they use variables.
+            m_state.style()->setHasExplicitlyInheritedProperties();

[esprehn, 2013/07/04 02:48:52]

This doesn't seem related to the patch?

[alancutter (OOO until 2018), 2013/07/04 06:18:14]

This fixes a bug which is only observable when CSSOM is introduced and  CSS
values are changed at runtime.
I could fix it in a separate patch but I would not be able to add test cases for
it. The tests that come with this patch test that the bug is fixed.

+        }
     }
 }
 
 void StyleResolver::applyProperty(CSSPropertyID id, CSSValue* value)
 {
     if (id != CSSPropertyVariable && hasVariableReference(value)) {
         Vector<std::pair<CSSPropertyID, String> > knownExpressions;
         resolveVariables(id, value, knownExpressions);
         return;
     }
@@ skipping 1086 matching lines @@
     info.addMember(m_state, "state");
 
     // FIXME: move this to a place where it would be called only once?
     info.addMember(CSSDefaultStyleSheets::defaultStyle, "defaultStyle");
     info.addMember(CSSDefaultStyleSheets::defaultQuirksStyle, "defaultQuirksStyle");
     info.addMember(CSSDefaultStyleSheets::defaultPrintStyle, "defaultPrintStyle");
     info.addMember(CSSDefaultStyleSheets::defaultViewSourceStyle, "defaultViewSourceStyle");
 }
 
 } // namespace WebCore