Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 1831083002: cc: Force a redraw on initializing a new output surface for remote compositor. (Closed)

Created:
4 years, 9 months ago by Khushal
Modified:
4 years, 9 months ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Force a redraw on initializing a new output surface for remote compositor. When the output surface is lost, the LTHI drops all resources and tiles, and waits for the next commit for the next draw. This commit might early out with no updates in which case we will never perform raster new tiles and redraw. Schedule a draw when a new output is surface is initialized to avoid this. BUG=597710 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/01dc424291863fcaa3a36c3de7e91bfae6172c42 Cr-Commit-Position: refs/heads/master@{#383204}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comments. #

Patch Set 3 : Missed updating the test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -8 lines) Patch
M cc/test/layer_tree_test.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M cc/test/layer_tree_test.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M cc/trees/remote_channel_impl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M cc/trees/remote_channel_impl.cc View 1 3 chunks +15 lines, -3 lines 0 comments Download
M cc/trees/remote_channel_unittest.cc View 1 2 1 chunk +16 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Khushal
4 years, 9 months ago (2016-03-24 19:06:00 UTC) #3
vmpstr
lgtm https://codereview.chromium.org/1831083002/diff/1/cc/trees/remote_channel_impl.h File cc/trees/remote_channel_impl.h (right): https://codereview.chromium.org/1831083002/diff/1/cc/trees/remote_channel_impl.h#newcode199 cc/trees/remote_channel_impl.h:199: void PostSetNeedsRedrawToImpl(gfx::Rect damaged_rect); const gfx::Rect&
4 years, 9 months ago (2016-03-24 20:57:30 UTC) #4
Khushal
Thanks! https://codereview.chromium.org/1831083002/diff/1/cc/trees/remote_channel_impl.h File cc/trees/remote_channel_impl.h (right): https://codereview.chromium.org/1831083002/diff/1/cc/trees/remote_channel_impl.h#newcode199 cc/trees/remote_channel_impl.h:199: void PostSetNeedsRedrawToImpl(gfx::Rect damaged_rect); On 2016/03/24 20:57:30, vmpstr wrote: ...
4 years, 9 months ago (2016-03-24 21:06:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1831083002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1831083002/20001
4 years, 9 months ago (2016-03-24 21:06:52 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/194096)
4 years, 9 months ago (2016-03-24 21:55:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1831083002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1831083002/40001
4 years, 9 months ago (2016-03-24 23:26:27 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-25 00:32:53 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 00:34:15 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/01dc424291863fcaa3a36c3de7e91bfae6172c42
Cr-Commit-Position: refs/heads/master@{#383204}

Powered by Google App Engine
This is Rietveld 408576698