Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Side by Side Diff: cc/trees/remote_channel_unittest.cc

Issue 1831083002: cc: Force a redraw on initializing a new output surface for remote compositor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Missed updating the test. Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « cc/trees/remote_channel_impl.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "cc/test/begin_frame_args_test.h" 5 #include "cc/test/begin_frame_args_test.h"
6 #include "cc/test/layer_tree_test.h" 6 #include "cc/test/layer_tree_test.h"
7 7
8 namespace cc { 8 namespace cc {
9 9
10 class RemoteChannelTest : public LayerTreeTest { 10 class RemoteChannelTest : public LayerTreeTest {
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 calls_received_++; 72 calls_received_++;
73 EndTest(); 73 EndTest();
74 } 74 }
75 75
76 void AfterTest() override { EXPECT_EQ(1, calls_received_); } 76 void AfterTest() override { EXPECT_EQ(1, calls_received_); }
77 }; 77 };
78 78
79 REMOTE_DIRECT_RENDERER_TEST_F(RemoteChannelTestDeferCommits); 79 REMOTE_DIRECT_RENDERER_TEST_F(RemoteChannelTestDeferCommits);
80 80
81 class RemoteChannelTestNeedsRedraw : public RemoteChannelTest { 81 class RemoteChannelTestNeedsRedraw : public RemoteChannelTest {
82 public:
83 RemoteChannelTestNeedsRedraw()
84 : damaged_rect_(4, 5), device_viewport_size_(0, 0) {}
85
82 void BeginChannelTest() override { 86 void BeginChannelTest() override {
83 damaged_rect_.set_width(4); 87 device_viewport_size_ =
84 damaged_rect_.set_height(5); 88 gfx::Rect(remote_client_layer_tree_host()->device_viewport_size());
85 layer_tree_host()->SetNeedsRedrawRect(damaged_rect_); 89 layer_tree_host()->SetNeedsRedrawRect(damaged_rect_);
86 } 90 }
87 91
88 void SetNeedsRedrawOnImpl(const gfx::Rect& damage_rect) override { 92 void SetNeedsRedrawOnImpl(const gfx::Rect& damage_rect) override {
89 EXPECT_EQ(damage_rect, damaged_rect_);
90 calls_received_++; 93 calls_received_++;
91 EndTest(); 94 if (calls_received_ == 1) {
95 EXPECT_EQ(damaged_rect_, damage_rect);
96 } else {
97 // The second call is received after the output surface is successfully
98 // initialized.
99 EXPECT_EQ(device_viewport_size_, damage_rect);
100 EndTest();
101 }
92 } 102 }
93 103
94 void AfterTest() override { EXPECT_EQ(1, calls_received_); } 104 void AfterTest() override { EXPECT_EQ(2, calls_received_); }
95 105
96 gfx::Rect damaged_rect_; 106 gfx::Rect damaged_rect_;
107 gfx::Rect device_viewport_size_;
97 }; 108 };
98 109
99 REMOTE_DIRECT_RENDERER_TEST_F(RemoteChannelTestNeedsRedraw); 110 REMOTE_DIRECT_RENDERER_TEST_F(RemoteChannelTestNeedsRedraw);
100 111
101 class RemoteChannelTestReleaseOutputSurface : public RemoteChannelTest { 112 class RemoteChannelTestReleaseOutputSurface : public RemoteChannelTest {
102 void DidInitializeOutputSurface() override { 113 void DidInitializeOutputSurface() override {
103 SetVisibleOnLayerTreeHost(false); 114 SetVisibleOnLayerTreeHost(false);
104 ReleaseOutputSurfaceOnLayerTreeHost(); 115 ReleaseOutputSurfaceOnLayerTreeHost();
105 } 116 }
106 117
(...skipping 115 matching lines...) Expand 10 before | Expand all | Expand 10 after
222 } 233 }
223 234
224 int output_surface_initialized_count_; 235 int output_surface_initialized_count_;
225 int commit_count_; 236 int commit_count_;
226 }; 237 };
227 238
228 REMOTE_DIRECT_RENDERER_TEST_F( 239 REMOTE_DIRECT_RENDERER_TEST_F(
229 RemoteChannelTestReleaseOutputSurfaceDuringCommit); 240 RemoteChannelTestReleaseOutputSurfaceDuringCommit);
230 241
231 } // namespace cc 242 } // namespace cc
OLDNEW
« no previous file with comments | « cc/trees/remote_channel_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698