Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 1830943002: Revert of Delete SkImageDecoder (Closed)

Created:
4 years, 9 months ago by msarett
Modified:
4 years, 9 months ago
Reviewers:
scroggo, djsollen
CC:
reviews_skia.org, dogben_google.com
Base URL:
https://skia.googlesource.com/skia.git@fix-animator
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Delete SkImageDecoder (patchset #9 id:150001 of https://codereview.chromium.org/1820503002/ ) Reason for revert: Roll still failing Original issue's description: > Delete SkImageDecoder > > This image decoding implementation has been replaced > by SkCodec in Android. > > Additionally, we have replaced uses of SkImageDecoder > in Skia and Google3 with uses of SkCodec. > > Now we can delete SkImageDecoder :). > > BUG=skia: > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1820503002 > CQ_EXTRA_TRYBOTS=client.skia.compile:Build-Ubuntu-GCC-x86_64-Release-CMake-Trybot,Build-Mac-Clang-x86_64-Release-CMake-Trybot > > Committed: https://skia.googlesource.com/skia/+/f799706656f2581c5bf5510d94df3fa17cce1607 > > Committed: https://skia.googlesource.com/skia/+/5b6e73e0c8282c4d85accbfbcecc6dee84f8a1eb > > Committed: https://skia.googlesource.com/skia/+/f037fdebda2a2626e6512d7532063f2cd41a264d TBR=scroggo@google.com,djsollen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/910f7ec7e79cd051f69b47c3e19d4fda2adbcef4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6758 lines, -49 lines) Patch
M cmake/CMakeLists.txt View 1 chunk +1 line, -0 lines 0 comments Download
M gm/downsamplebitmap.cpp View 1 chunk +8 lines, -0 lines 0 comments Download
A gm/etc1bitmap.cpp View 1 chunk +223 lines, -0 lines 0 comments Download
M gyp/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/images.gyp View 5 chunks +28 lines, -1 line 0 comments Download
M include/core/SkCanvas.h View 2 chunks +1 line, -1 line 0 comments Download
A include/core/SkImageDecoder.h View 1 chunk +413 lines, -0 lines 0 comments Download
M include/core/SkImageEncoder.h View 1 chunk +2 lines, -6 lines 0 comments Download
M include/core/SkPicture.h View 1 chunk +1 line, -4 lines 0 comments Download
M include/core/SkPngChunkReader.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkWriteBuffer.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/android/SkBitmapRegionDecoder.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkBigPicture.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/core/SkLayerInfo.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/GrLayerCache.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/images/SkForceLinking.cpp View 2 chunks +15 lines, -11 lines 0 comments Download
A src/images/SkImageDecoder.cpp View 1 chunk +204 lines, -0 lines 0 comments Download
M src/images/SkImageDecoder_FactoryDefault.cpp View 1 chunk +9 lines, -0 lines 0 comments Download
A src/images/SkImageDecoder_FactoryRegistrar.cpp View 1 chunk +63 lines, -0 lines 0 comments Download
A src/images/SkImageDecoder_astc.cpp View 1 chunk +203 lines, -0 lines 0 comments Download
M src/images/SkImageDecoder_ktx.cpp View 3 chunks +239 lines, -5 lines 0 comments Download
A src/images/SkImageDecoder_libbmp.cpp View 1 chunk +166 lines, -0 lines 0 comments Download
A src/images/SkImageDecoder_libgif.cpp View 1 chunk +541 lines, -0 lines 0 comments Download
A src/images/SkImageDecoder_libico.cpp View 1 chunk +456 lines, -0 lines 0 comments Download
M src/images/SkImageDecoder_libjpeg.cpp View 3 chunks +756 lines, -1 line 0 comments Download
M src/images/SkImageDecoder_libpng.cpp View 4 chunks +681 lines, -4 lines 0 comments Download
M src/images/SkImageDecoder_libwebp.cpp View 3 chunks +313 lines, -1 line 0 comments Download
A src/images/SkImageDecoder_pkm.cpp View 1 chunk +128 lines, -0 lines 0 comments Download
A src/images/SkImageDecoder_wbmp.cpp View 1 chunk +173 lines, -0 lines 0 comments Download
M src/images/SkJpegUtility.h View 2 chunks +18 lines, -0 lines 0 comments Download
M src/images/SkJpegUtility.cpp View 1 chunk +102 lines, -0 lines 0 comments Download
A src/images/SkScaledBitmapSampler.h View 1 chunk +107 lines, -0 lines 0 comments Download
A src/images/SkScaledBitmapSampler.cpp View 1 chunk +877 lines, -0 lines 0 comments Download
A src/images/bmpdecoderhelper.h View 1 chunk +116 lines, -0 lines 0 comments Download
A src/images/bmpdecoderhelper.cpp View 1 chunk +369 lines, -0 lines 0 comments Download
M src/ports/SkImageDecoder_CG.cpp View 3 chunks +252 lines, -3 lines 0 comments Download
M src/ports/SkImageDecoder_WIC.cpp View 4 chunks +227 lines, -5 lines 0 comments Download
M src/ports/SkImageDecoder_empty.cpp View 1 chunk +63 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
msarett
Created Revert of Delete SkImageDecoder
4 years, 9 months ago (2016-03-24 11:45:19 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1830943002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1830943002/1
4 years, 9 months ago (2016-03-24 11:45:28 UTC) #2
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 11:45:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/910f7ec7e79cd051f69b47c3e19d4fda2adbcef4

Powered by Google App Engine
This is Rietveld 408576698