Issue 18309004: Web MIDI: prepare to pass a security origin from blink to browser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18309004: Web MIDI: prepare to pass a security origin from blink to browser (Closed)

Created:
7 years, 5 months ago by Takashi Toyoshima

Modified:
7 years, 5 months ago

Reviewers:

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Web MIDI: prepare to pass a security origin from blink to browser Permission will be managed in browser process and needs security origin. This change prepares to pass a security origin from blink to browser. Once blink side API change is landed, old API will be removed soon. BUG=163795 TEST=none

Patch Set 1 #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+33 lines, -12 lines)			Patch
M	content/browser/renderer_host/media/midi_host.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/renderer_host/media/midi_host.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	content/common/media/midi_messages.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	content/renderer/media/midi_message_filter.h	View	2 chunks	+6 lines, -2 lines	0 comments	Download
M	content/renderer/media/midi_message_filter.cc	View	2 chunks	+8 lines, -5 lines	0 comments	Download
M	content/renderer/media/renderer_webmidiaccessor_impl.h	View	1 chunk	+5 lines, -1 line	0 comments	Download
M	content/renderer/media/renderer_webmidiaccessor_impl.cc	View	1 chunk	+6 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Takashi Toyoshima

scherkus, crogers: Hi, I'm working on Web MIDI sysex permission handling and this change will ...

7 years, 5 months ago (2013-07-01 13:08:28 UTC) #1

Takashi Toyoshima

FYI, here is the second change in blink side; https://codereview.chromium.org/18325007/ Also, the third change to ...

7 years, 5 months ago (2013-07-01 13:31:08 UTC) #2

Takashi Toyoshima

7 years, 5 months ago (2013-07-01 18:59:57 UTC) #3

Hi,
Adam Barth suggests another approach on an API change.
So, please stop reviewing this until API change gets approval.

Sorry for bothering you.

Expand Messages | Collapse Messages