Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 1830563003: Fix language test that failed on mips hardware, because the created NaN happened (Closed)

Created:
4 years, 9 months ago by regis
Modified:
4 years, 9 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix language test that failed on mips hardware, because the created NaN happened to be identical to the NaN resulting of a division of 0.0 by 0.0. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/9d50701d506eee67fbcd3ded06aaf05a37e05ed7

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M tests/language/nan_identical_test.dart View 1 1 chunk +6 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
regis
4 years, 9 months ago (2016-03-23 22:07:22 UTC) #2
rmacnak
lgtm https://codereview.chromium.org/1830563003/diff/1/tests/language/nan_identical_test.dart File tests/language/nan_identical_test.dart (right): https://codereview.chromium.org/1830563003/diff/1/tests/language/nan_identical_test.dart#newcode16 tests/language/nan_identical_test.dart:16: return bdata.getFloat64(0); var result = bdata.getFloat64(0); Expect.isTrue(result.isNaN); return ...
4 years, 9 months ago (2016-03-23 22:12:11 UTC) #3
regis
Thanks! I also fixed the unexpected endianess of typed data. https://codereview.chromium.org/1830563003/diff/1/tests/language/nan_identical_test.dart File tests/language/nan_identical_test.dart (right): https://codereview.chromium.org/1830563003/diff/1/tests/language/nan_identical_test.dart#newcode16 ...
4 years, 9 months ago (2016-03-23 22:42:59 UTC) #4
regis
4 years, 9 months ago (2016-03-23 22:59:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9d50701d506eee67fbcd3ded06aaf05a37e05ed7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698