Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: tests/language/nan_identical_test.dart

Issue 1830563003: Fix language test that failed on mips hardware, because the created NaN happened (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: address comment Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // Test a new statement by itself. 4 // Test a new statement by itself.
5 // VMOptions=--optimization-counter-threshold=4 --no-background-compilation 5 // VMOptions=--optimization-counter-threshold=4 --no-background-compilation
6 6
7 import 'dart:typed_data'; 7 import 'dart:typed_data';
8 8
9 import "package:expect/expect.dart"; 9 import "package:expect/expect.dart";
10 10
11 double uint64toDouble(int i) { 11 double createOtherNAN() {
12 var buffer = new Uint8List(8).buffer; 12 var buffer = new Uint8List(8).buffer;
13 var bdata = new ByteData.view(buffer); 13 var bdata = new ByteData.view(buffer);
14 bdata.setUint64(0, i); 14 bdata.setFloat64(0, double.NAN);
15 return bdata.getFloat64(0); 15 bdata.setInt8(7, bdata.getInt8(7) ^ 1); // Flip bit 0, big endian.
16 } 16 double result = bdata.getFloat64(0);
17 17 Expect.isTrue(result.isNaN);
18 double createOtherNAN() { 18 return result;
19 return uint64toDouble((1 << 64) - 2);
20 } 19 }
21 20
22 main() { 21 main() {
23 var otherNAN = createOtherNAN(); 22 var otherNAN = createOtherNAN();
24 for (int i = 0; i < 100; i++) { 23 for (int i = 0; i < 100; i++) {
25 Expect.isFalse(checkIdentical(double.NAN, -double.NAN)); 24 Expect.isFalse(checkIdentical(double.NAN, -double.NAN));
26 Expect.isTrue(checkIdentical(double.NAN, double.NAN)); 25 Expect.isTrue(checkIdentical(double.NAN, double.NAN));
27 Expect.isTrue(checkIdentical(-double.NAN, -double.NAN)); 26 Expect.isTrue(checkIdentical(-double.NAN, -double.NAN));
28 27
29 Expect.isFalse(checkIdentical(otherNAN, -otherNAN)); 28 Expect.isFalse(checkIdentical(otherNAN, -otherNAN));
(...skipping 12 matching lines...) Expand all
42 Expect.isFalse(checkIdentical(-a, -b)); 41 Expect.isFalse(checkIdentical(-a, -b));
43 Expect.isFalse(checkIdentical(-a, b)); 42 Expect.isFalse(checkIdentical(-a, b));
44 Expect.isFalse(checkIdentical(a, -b)); 43 Expect.isFalse(checkIdentical(a, -b));
45 44
46 Expect.isTrue(checkIdentical(-(-a), a)); 45 Expect.isTrue(checkIdentical(-(-a), a));
47 Expect.isTrue(checkIdentical(-(-b), b)); 46 Expect.isTrue(checkIdentical(-(-b), b));
48 } 47 }
49 } 48 }
50 49
51 checkIdentical(a, b) => identical(a, b); 50 checkIdentical(a, b) => identical(a, b);
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698