Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Unified Diff: remoting/host/setup/test_util.cc

Issue 1830433002: Adding the message writing class used for remote_security_key STDOUT communication. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@messages
Patch Set: Integrating security message changes Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/setup/test_util.cc
diff --git a/remoting/host/setup/test_util.cc b/remoting/host/setup/test_util.cc
index ad80af6399ecd65c831bea8f19f2abb695b7023c..efdb58362e0289725651a23113aa3a64a5d8d8ab 100644
--- a/remoting/host/setup/test_util.cc
+++ b/remoting/host/setup/test_util.cc
@@ -15,10 +15,16 @@ namespace remoting {
bool MakePipe(base::File* read_file,
base::File* write_file) {
+ return MakePipe(read_file, write_file, 0);
+}
+
+bool MakePipe(base::File* read_file,
+ base::File* write_file,
+ unsigned int buffer_size_bytes) {
Sergey Ulanov 2016/03/28 18:26:43 This parameter is windows-specific. I suggest wrap
joedow 2016/03/29 22:14:14 Acknowledged.
#if defined(OS_WIN)
base::PlatformFile read_handle;
base::PlatformFile write_handle;
- if (!CreatePipe(&read_handle, &write_handle, nullptr, 0))
+ if (!CreatePipe(&read_handle, &write_handle, nullptr, buffer_size_bytes))
return false;
*read_file = base::File(read_handle);
*write_file = base::File(write_handle);

Powered by Google App Engine
This is Rietveld 408576698