Adding the message writing class used for remote_security_key STDOUT communication.

remoting/host/setup/test_util.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "build/build_config.h"
 #include "remoting/host/setup/test_util.h"
 
 #if defined(OS_WIN)
 #include <windows.h>
 #elif defined(OS_POSIX)
 #include <unistd.h>
 #endif
 
 namespace remoting {
 
 bool MakePipe(base::File* read_file,
               base::File* write_file) {
+  return MakePipe(read_file, write_file, 0);
+}
+
+bool MakePipe(base::File* read_file,
+              base::File* write_file,
+              unsigned int buffer_size_bytes) {

[Sergey Ulanov, 2016/03/28 18:26:43]

This parameter is windows-specific. I suggest wrapping this function in ifdef,
so that't it's not defined on other platforms. Also my comment about function
overloading applies here as well.

[joedow, 2016/03/29 22:14:14]

Acknowledged.

 #if defined(OS_WIN)
   base::PlatformFile read_handle;
   base::PlatformFile write_handle;
-  if (!CreatePipe(&read_handle, &write_handle, nullptr, 0))
+  if (!CreatePipe(&read_handle, &write_handle, nullptr, buffer_size_bytes))
     return false;
   *read_file = base::File(read_handle);
   *write_file = base::File(write_handle);
   return true;
 #elif defined(OS_POSIX)
   int fds[2];
   if (pipe(fds) == 0) {
     *read_file = base::File(fds[0]);
     *write_file = base::File(fds[1]);
     return true;
   }
   return false;
 #else
 #error Not implemented
 #endif
 }
 
 }  // namepsace remoting