Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1830403002: switch package to strong mode (Closed)

Created:
4 years, 9 months ago by Jennifer Messerly
Modified:
4 years, 9 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/code_transformers.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : use async #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -53 lines) Patch
A .analysis_options View 1 chunk +2 lines, -0 lines 0 comments Download
M CHANGELOG.md View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M lib/assets.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/messages/build_logger.dart View 5 chunks +8 lines, -9 lines 0 comments Download
M lib/messages/messages.dart View 3 chunks +6 lines, -2 lines 0 comments Download
M lib/src/async_benchmark_base.dart View 1 1 chunk +10 lines, -12 lines 0 comments Download
M lib/src/dart_sdk.dart View 3 chunks +4 lines, -2 lines 0 comments Download
M lib/src/resolver_impl.dart View 12 chunks +16 lines, -18 lines 0 comments Download
M lib/src/resolvers.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/assets_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M test/resolver_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Jennifer Messerly
4 years, 9 months ago (2016-03-25 00:07:19 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/1830403002/diff/20001/lib/src/resolvers.dart File lib/src/resolvers.dart (right): https://codereview.chromium.org/1830403002/diff/20001/lib/src/resolvers.dart#newcode97 lib/src/resolvers.dart:97: /// By default only process possible entry point ...
4 years, 9 months ago (2016-03-25 00:21:00 UTC) #4
Jennifer Messerly
Thanks! https://codereview.chromium.org/1830403002/diff/20001/lib/src/resolvers.dart File lib/src/resolvers.dart (right): https://codereview.chromium.org/1830403002/diff/20001/lib/src/resolvers.dart#newcode97 lib/src/resolvers.dart:97: /// By default only process possible entry point ...
4 years, 9 months ago (2016-03-25 00:32:33 UTC) #5
Jennifer Messerly
Committed patchset #3 (id:40001) manually as cde6c50501ba4a8d2291e6e852ab1d2c907c2e85 (presubmit successful).
4 years, 9 months ago (2016-03-25 00:32:43 UTC) #7
Jennifer Messerly
if one of you doesn't mind pushing a release, that'd be grand :) that way ...
4 years, 9 months ago (2016-03-25 00:33:50 UTC) #8
Siggi Cherem (dart-lang)
4 years, 9 months ago (2016-03-25 00:50:10 UTC) #9
Message was sent while issue was closed. 
all set :)

Powered by Google App Engine
This is Rietveld 408576698