Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 183033004: Cleanup shill_stub_helper, GetSharedProfilePath -> ShillProfileClient (Closed)

Created:
6 years, 9 months ago by stevenjb
Modified:
6 years, 9 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, sadrul, nkostylev+watch_chromium.org, ben+ash_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kalyank, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Cleanup shill_stub_helper, GetSharedProfilePath -> ShillProfileClient Also replaces IsStubPortalledWifiEnabled() with more robust logic. BUG=345033 R=pneubeck@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254492

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix spelling #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -82 lines) Patch
M ash/system/chromeos/network/network_connect.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/net/network_portal_detector_impl.cc View 3 chunks +12 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_apitest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chromeos/dbus/fake_shill_service_client.cc View 3 chunks +5 lines, -2 lines 0 comments Download
M chromeos/dbus/shill_profile_client.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chromeos/dbus/shill_profile_client.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M chromeos/dbus/shill_stub_helper.h View 1 chunk +0 lines, -8 lines 0 comments Download
M chromeos/dbus/shill_stub_helper.cc View 1 8 chunks +22 lines, -49 lines 0 comments Download
M chromeos/network/favorite_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/managed_network_configuration_handler_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/network/network_configuration_handler_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chromeos/network/network_connection_handler.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chromeos/network/network_profile_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/network/network_profile_handler.cc View 1 chunk +3 lines, -1 line 0 comments Download
M chromeos/network/network_state.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
stevenjb
This is some cleanup extracted form a larger CL (https://codereview.chromium.org/181413006/) designed to simplify the flags ...
6 years, 9 months ago (2014-02-28 19:01:08 UTC) #1
pneubeck (no reviews)
thanks for the splitting. this part lgtm. https://codereview.chromium.org/183033004/diff/1/chromeos/dbus/shill_stub_helper.cc File chromeos/dbus/shill_stub_helper.cc (right): https://codereview.chromium.org/183033004/diff/1/chromeos/dbus/shill_stub_helper.cc#newcode124 chromeos/dbus/shill_stub_helper.cc:124: const std::string ...
6 years, 9 months ago (2014-02-28 20:25:56 UTC) #2
stevenjb
https://codereview.chromium.org/183033004/diff/1/chromeos/dbus/shill_stub_helper.cc File chromeos/dbus/shill_stub_helper.cc (right): https://codereview.chromium.org/183033004/diff/1/chromeos/dbus/shill_stub_helper.cc#newcode124 chromeos/dbus/shill_stub_helper.cc:124: const std::string kPortaledWifiPath = "portalled_wifi"; On 2014/02/28 20:25:57, pneubeck ...
6 years, 9 months ago (2014-02-28 20:29:00 UTC) #3
stevenjb
6 years, 9 months ago (2014-03-03 17:26:39 UTC) #4
Message was sent while issue was closed. 
Committed patchset #3 manually as r254492 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698