Cleanup shill_stub_helper, GetSharedProfilePath -> ShillProfileClient

chromeos/dbus/shill_stub_helper.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/dbus/shill_stub_helper.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/strings/string_tokenizer.h"
 #include "chromeos/chromeos_switches.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
 #include "chromeos/dbus/shill_device_client.h"
 #include "chromeos/dbus/shill_manager_client.h"
 #include "chromeos/dbus/shill_profile_client.h"
 #include "chromeos/dbus/shill_service_client.h"
 #include "third_party/cros_system_api/dbus/service_constants.h"
 
 namespace chromeos {
 namespace shill_stub_helper {
 
 namespace {
 
-const char kDevicePathEthernet[] = "/device/eth1";
-const char kDevicePathWifi[] = "/device/wifi1";
-const char kDevicePathCellular[] = "/device/cellular1";
-const char kDevicePathWimax[] = "/device/wimax1";
-
-const char kStubPortalledWifiName[] = "Portalled Wifi";
-const char kStubPortalledWifiPath[] = "portalled_wifi";
-
-void UpdatePortalledWifiState() {
+void UpdatePortalledWifiState(const std::string& service_path) {
   ShillServiceClient::TestInterface* services =
       DBusThreadManager::Get()->GetShillServiceClient()->GetTestInterface();
 
-  services->SetServiceProperty(kStubPortalledWifiPath,
+  services->SetServiceProperty(service_path,
                                shill::kStateProperty,
                                base::StringValue(shill::kStatePortal));
 }
 
 // Returns true if |network_type| is found in the comma separated list given
 // with kEnabledStubNetworkTypes switch.
 bool IsStubNetworkTypeEnabled(const std::string& network_type) {
   CommandLine* command_line = CommandLine::ForCurrentProcess();
   // If the switch is not present, enabled by default.
   if (!command_line->HasSwitch(switches::kEnabledStubNetworkTypes))
     return true;
 
   const std::string value =
       command_line->GetSwitchValueASCII(switches::kEnabledStubNetworkTypes);
   base::StringTokenizer tokenizer(value, ",");
   while (tokenizer.GetNext()) {
     if (tokenizer.token() == network_type)
       return true;
   }
   return false;
 }
 
 }  // namespace
 
-const char kSharedProfilePath[] = "/profile/default";
-
-bool IsStubPortalledWifiEnabled(const std::string& path) {
-  if (!CommandLine::ForCurrentProcess()->HasSwitch(
-           chromeos::switches::kEnableStubPortalledWifi)) {
-    return false;
-  }
-  return path == kStubPortalledWifiPath;
-}
-
 void SetupDefaultEnvironment() {
   ShillServiceClient::TestInterface* services =
       DBusThreadManager::Get()->GetShillServiceClient()->GetTestInterface();
   ShillProfileClient::TestInterface* profiles =
       DBusThreadManager::Get()->GetShillProfileClient()->GetTestInterface();
   ShillManagerClient::TestInterface* manager =
       DBusThreadManager::Get()->GetShillManagerClient()->GetTestInterface();
   ShillDeviceClient::TestInterface* devices =
       DBusThreadManager::Get()->GetShillDeviceClient()->GetTestInterface();
   if (!services || !profiles || !manager | !devices)
     return;
 
   // Stub Technologies.
   manager->AddTechnology(shill::kTypeEthernet, true);
   manager->AddTechnology(shill::kTypeWifi, true);
   manager->AddTechnology(shill::kTypeCellular, true);
   manager->AddTechnology(shill::kTypeWimax, true);
 
-  profiles->AddProfile(kSharedProfilePath, std::string());
+  std::string shared_profile = ShillProfileClient::GetSharedProfilePath();
+  profiles->AddProfile(shared_profile, std::string());
+
+  devices->AddDevice("/device/eth1", shill::kTypeEthernet, "stub_eth_device1");
+  devices->AddDevice("/device/wifi1", shill::kTypeWifi, "stub_wifi_device1");
 
   devices->AddDevice(
-      kDevicePathEthernet, shill::kTypeEthernet, "stub_eth_device1");
-  devices->AddDevice(kDevicePathWifi, shill::kTypeWifi, "stub_wifi_device1");
-
-  devices->AddDevice(
-      kDevicePathCellular, shill::kTypeCellular, "stub_cellular_device1");
-  devices->SetDeviceProperty(kDevicePathCellular,
+      "/device/cellular1", shill::kTypeCellular, "stub_cellular_device1");
+  devices->SetDeviceProperty("/device/cellular1",
                              shill::kCarrierProperty,
                              base::StringValue(shill::kCarrierSprint));
 
-  devices->AddDevice(kDevicePathWimax, shill::kTypeWimax, "stub_wimax_device1");
+  devices->AddDevice("/device/wimax1", shill::kTypeWimax, "stub_wimax_device1");
 
   const bool add_to_visible = true;
   const bool add_to_watchlist = true;
 
   // On real devices, service is not added for ethernet if cable is disconneted.
   if (IsStubNetworkTypeEnabled(shill::kTypeEthernet)) {
     services->AddService("eth1", "eth1",
                          shill::kTypeEthernet,
                          shill::kStateOnline,
                          add_to_visible, add_to_watchlist);
-    profiles->AddService(kSharedProfilePath, "eth1");
+    profiles->AddService(shared_profile, "eth1");
   }
 
   // Wifi
 
   services->AddService("wifi1",
                        "wifi1",
                        shill::kTypeWifi,
                        IsStubNetworkTypeEnabled(shill::kTypeWifi) ?
                            shill::kStateOnline : shill::kStateIdle,
                        add_to_visible, add_to_watchlist);
   services->SetServiceProperty("wifi1",
                                shill::kSecurityProperty,
                                base::StringValue(shill::kSecurityWep));
-  profiles->AddService(kSharedProfilePath, "wifi1");
+  profiles->AddService(shared_profile, "wifi1");
 
   services->AddService("wifi2",
                        "wifi2_PSK",
                        shill::kTypeWifi,
                        shill::kStateIdle,
                        add_to_visible, add_to_watchlist);
   services->SetServiceProperty("wifi2",
                                shill::kSecurityProperty,
                                base::StringValue(shill::kSecurityPsk));
   base::FundamentalValue strength_value(80);
   services->SetServiceProperty(
       "wifi2", shill::kSignalStrengthProperty, strength_value);
-  profiles->AddService(kSharedProfilePath, "wifi2");
+  profiles->AddService(shared_profile, "wifi2");
 
   if (CommandLine::ForCurrentProcess()->HasSwitch(
           chromeos::switches::kEnableStubPortalledWifi)) {
-    services->AddService(kStubPortalledWifiPath,
-                         kStubPortalledWifiName,
+    const std::string kPortaledWifiPath = "portalled_wifi";

[pneubeck (no reviews), 2014/02/28 20:25:57]

typo: Portaled -> Portalled

[stevenjb, 2014/02/28 20:29:00]

Done.

+    services->AddService(kPortaledWifiPath,
+                         "Portalled Wifi",
                          shill::kTypeWifi,
                          shill::kStatePortal,
                          add_to_visible, add_to_watchlist);
-    services->SetServiceProperty(kStubPortalledWifiPath,
+    services->SetServiceProperty(kPortaledWifiPath,
                                  shill::kSecurityProperty,
                                  base::StringValue(shill::kSecurityNone));
-    services->SetConnectBehavior(kStubPortalledWifiPath,
-                                 base::Bind(&UpdatePortalledWifiState));
-    services->SetServiceProperty(kStubPortalledWifiPath,
+    services->SetConnectBehavior(kPortaledWifiPath,
+                                 base::Bind(&UpdatePortalledWifiState,
+                                            kPortaledWifiPath));
+    services->SetServiceProperty(kPortaledWifiPath,
                                  shill::kConnectableProperty,
                                  base::FundamentalValue(true));
+    profiles->AddService(shared_profile, kPortaledWifiPath);

[pneubeck (no reviews), 2014/02/28 20:25:57]

was that missing before?

[stevenjb, 2014/02/28 20:29:00]

Yes. It was causing warning spam in NetworkStateHandler (connected secure
networks are expected to be favorites).

   }
 
   // Wimax
 
   services->AddService("wimax1",
                        "wimax1",
                        shill::kTypeWimax,
                        shill::kStateIdle,
                        add_to_visible, add_to_watchlist);
   services->SetServiceProperty(
@@ skipping 28 matching lines @@
   provider_properties.SetString(shill::kHostProperty, "vpn_host");
 
   services->AddService("vpn1",
                        "vpn1",
                        shill::kTypeVPN,
                        IsStubNetworkTypeEnabled(shill::kTypeVPN) ?
                            shill::kStateOnline : shill::kStateIdle,
                        add_to_visible, add_to_watchlist);
   services->SetServiceProperty(
       "vpn1", shill::kProviderProperty, provider_properties);
-  profiles->AddService(kSharedProfilePath, "vpn1");
+  profiles->AddService(shared_profile, "vpn1");
 
   services->AddService("vpn2",
                        "vpn2",
                        shill::kTypeVPN,
                        shill::kStateIdle,
                        add_to_visible, add_to_watchlist);
   services->SetServiceProperty(
       "vpn2", shill::kProviderProperty, provider_properties);
 
   manager->SortManagerServices();
 }
 
-std::string DevicePathForType(const std::string& type) {
-  if (type == shill::kTypeEthernet)
-    return kDevicePathEthernet;
-  if (type == shill::kTypeWifi)
-    return kDevicePathWifi;
-  if (type == shill::kTypeCellular)
-    return kDevicePathCellular;
-  if (type == shill::kTypeWimax)
-    return kDevicePathWimax;
-  return "";
-}
-
 }  // namespace shill_stub_helper
 }  // namespace chromeos