Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1830193002: Move buffer_presented_params_mac to content/common (Closed)

Created:
4 years, 9 months ago by Fady Samuel
Modified:
4 years, 9 months ago
Reviewers:
dcheng, piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move buffer_presented_params_mac to content/common This is an IPC struct used by gpu_host_messages.h so it doesn't really belong to content/common/gpu and later gpu/ipc/common BUG=596290 Committed: https://crrev.com/f862957acd612cdb4730f964a7fd07201f841361 Cr-Commit-Position: refs/heads/master@{#383135}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -63 lines) Patch
A + content/common/buffer_presented_params_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + content/common/buffer_presented_params_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/common/gpu/buffer_presented_params_mac.h View 1 chunk +0 lines, -23 lines 0 comments Download
D content/common/gpu/buffer_presented_params_mac.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M content/common/gpu/gpu_channel_manager.h View 3 chunks +5 lines, -5 lines 0 comments Download
M content/common/gpu/gpu_channel_manager.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M content/common/gpu/image_transport_surface_overlay_mac.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M content/common/gpu/image_transport_surface_overlay_mac.mm View 1 2 chunks +5 lines, -4 lines 0 comments Download
M content/common/gpu_host_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/content_common.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M content/gpu/gpu_child_thread.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M content/gpu/gpu_child_thread.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Fady Samuel
4 years, 9 months ago (2016-03-24 14:59:12 UTC) #3
dcheng
ipc lgtm
4 years, 9 months ago (2016-03-24 15:12:46 UTC) #4
piman
lgtm
4 years, 9 months ago (2016-03-24 18:03:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1830193002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1830193002/20001
4 years, 9 months ago (2016-03-24 19:26:41 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-24 20:33:30 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 20:34:55 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f862957acd612cdb4730f964a7fd07201f841361
Cr-Commit-Position: refs/heads/master@{#383135}

Powered by Google App Engine
This is Rietveld 408576698