Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 1830133002: MIPS64: Replace JR/JALR with JIC/JIALC for r6. (Closed)

Created:
4 years, 9 months ago by miran.karic
Modified:
4 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS64: Replace JR/JALR with JIC/JIALC for r6. Port of changes that replace JR and JALR instructions with JIC and JIALC for mips64r6. Macroassembler Jump and Call functions now use JIC and JIALC if branch delay slot is not used. Code patching is adjusted to work with new changes. Jr and Jalr macroassembler functions are removed. Other changes where mips32r6 uses jr/jalr are not done because mips64r6 uses j/jal instructions. BUG= Committed: https://crrev.com/a3f941aed4afb475232b2d7d11179720d5e52fd6 Cr-Commit-Position: refs/heads/master@{#35141}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -65 lines) Patch
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 3 chunks +7 lines, -7 lines 0 comments Download
M src/mips64/assembler-mips64.h View 2 chunks +8 lines, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 4 chunks +35 lines, -56 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
miran.karic
4 years, 9 months ago (2016-03-24 13:17:45 UTC) #2
balazs.kilvady
Looks good. A nit: https://codereview.chromium.org/1830133002/diff/1/src/full-codegen/mips64/full-codegen-mips64.cc File src/full-codegen/mips64/full-codegen-mips64.cc (right): https://codereview.chromium.org/1830133002/diff/1/src/full-codegen/mips64/full-codegen-mips64.cc#newcode4070 src/full-codegen/mips64/full-codegen-mips64.cc:4070: } Could you use the ...
4 years, 9 months ago (2016-03-24 17:03:10 UTC) #3
miran.karic
https://codereview.chromium.org/1830133002/diff/1/src/full-codegen/mips64/full-codegen-mips64.cc File src/full-codegen/mips64/full-codegen-mips64.cc (right): https://codereview.chromium.org/1830133002/diff/1/src/full-codegen/mips64/full-codegen-mips64.cc#newcode4070 src/full-codegen/mips64/full-codegen-mips64.cc:4070: } On 2016/03/24 17:03:10, balazs.kilvady wrote: > Could you ...
4 years, 9 months ago (2016-03-25 09:30:09 UTC) #4
balazs.kilvady
LGTM. Please put a dot to the end of the 1st line of the description: ...
4 years, 8 months ago (2016-03-30 15:35:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1830133002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1830133002/40001
4 years, 8 months ago (2016-03-30 16:24:23 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-03-30 16:44:01 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 16:44:55 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a3f941aed4afb475232b2d7d11179720d5e52fd6
Cr-Commit-Position: refs/heads/master@{#35141}

Powered by Google App Engine
This is Rietveld 408576698