Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 183003009: Handle errors properly in FileUtilProxy::CreateTemporary. (Closed)

Created:
6 years, 9 months ago by davidben
Modified:
6 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews, erikwright+watch_chromium.org
Visibility:
Public.

Description

Handle errors properly in FileUtilProxy::CreateTemporary. If creating the temporary file failed, don't try to open it. If we can't open it for some reason, delete the temporary so the caller can assume strong exception safety and not have to delete the file on error. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=255767

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M base/files/file_util_proxy.cc View 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
davidben
This code has exactly one caller (RedirectToFileResourceHandler) and it doesn't handle errors either, but in ...
6 years, 9 months ago (2014-03-03 22:42:35 UTC) #1
brettw
lgtm
6 years, 9 months ago (2014-03-07 18:12:54 UTC) #2
davidben
The CQ bit was checked by davidben@chromium.org
6 years, 9 months ago (2014-03-07 18:17:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/183003009/1
6 years, 9 months ago (2014-03-07 18:20:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/183003009/1
6 years, 9 months ago (2014-03-07 20:22:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/183003009/1
6 years, 9 months ago (2014-03-08 10:49:47 UTC) #6
commit-bot: I haz the power
6 years, 9 months ago (2014-03-08 13:04:51 UTC) #7
Message was sent while issue was closed.
Change committed as 255767

Powered by Google App Engine
This is Rietveld 408576698