Handle errors properly in FileUtilProxy::CreateTemporary.

base/files/file_util_proxy.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/file_util_proxy.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/file_util.h"
 #include "base/files/file.h"
@@ skipping 59 matching lines @@
   ~CreateTemporaryHelper() {
     if (file_handle_ != kInvalidPlatformFileValue) {
       FileUtilProxy::Close(
           task_runner_.get(), file_handle_, FileUtilProxy::StatusCallback());
     }
   }
 
   void RunWork(int additional_file_flags) {
     // TODO(darin): file_util should have a variant of CreateTemporaryFile
     // that returns a FilePath and a PlatformFile.
-    base::CreateTemporaryFile(&file_path_);
+    if (!base::CreateTemporaryFile(&file_path_)) {
+      // TODO(davidben): base::CreateTemporaryFile should preserve the error
+      // code.
+      error_ = File::FILE_ERROR_FAILED;
+      return;
+    }
 
     int file_flags =
         PLATFORM_FILE_WRITE |
         PLATFORM_FILE_TEMPORARY |
         PLATFORM_FILE_CREATE_ALWAYS |
         additional_file_flags;
 
     error_ = File::FILE_OK;
     // TODO(rvargas): Convert this code to use File.
     file_handle_ =
         CreatePlatformFile(file_path_, file_flags, NULL,
                            reinterpret_cast<PlatformFileError*>(&error_));
+    if (error_ != File::FILE_OK) {
+      base::DeleteFile(file_path_, false);
+      file_path_.clear();
+    }
   }
 
   void Reply(const FileUtilProxy::CreateTemporaryCallback& callback) {
     DCHECK(!callback.is_null());
     callback.Run(error_, PassPlatformFile(&file_handle_), file_path_);
   }
 
  private:
   scoped_refptr<TaskRunner> task_runner_;
   PlatformFile file_handle_;
@@ skipping 310 matching lines @@
 bool FileUtilProxy::RelayClose(
     TaskRunner* task_runner,
     const CloseTask& close_task,
     PlatformFile file_handle,
     const StatusCallback& callback) {
   return base::PostTaskAndReplyWithResult(
       task_runner, FROM_HERE, Bind(close_task, file_handle), callback);
 }
 
 }  // namespace base