Add some more logging to help diagnise component update issues.

Add some more logging to help diagnise component update issues.

Specifically, add more logging to CDM installer.

BUG=597289
Committed: https://crrev.com/1a34fd0293910fcb86f7c4366b8bbb6a2e3e9b6d
Cr-Commit-Position: refs/heads/master@{#382988}

[Sorin Jianu, 2016-03-23 23:22:50]

Description was changed from

==========
Add some more logging to help diagnise component update issues.

Specifically, add more logging to CDM installer.

BUG=597289
==========

to

==========
Add some more logging to help diagnise component update issues.

Specifically, add more logging to CDM installer.

BUG=597289
==========

[Sorin Jianu, 2016-03-23 23:22:50]

sorin@chromium.org changed reviewers:
+ waffles@chromium.org, xhwang@chromium.org

[Sorin Jianu, 2016-03-23 23:23:37]

I've added a few more logging statements in the default component installer and
CDM installer.

[waffles, 2016-03-23 23:29:19]

lgtm

[Sorin Jianu, 2016-03-24 00:20:56]

The CQ bit was checked by sorin@chromium.org

[commit-bot: I haz the power, 2016-03-24 00:21:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1830023002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1830023002/1

[Sorin Jianu, 2016-03-24 00:22:10]

Xiaohan, I am landing this so we can catch today's canary. Please send comments
and I will make the required changes.

[xhwang, 2016-03-24 00:22:54]

LGTM % one q

https://codereview.chromium.org/1830023002/diff/1/chrome/browser/component_up...
File chrome/browser/component_updater/widevine_cdm_component_installer.cc
(right):

https://codereview.chromium.org/1830023002/diff/1/chrome/browser/component_up...
chrome/browser/component_updater/widevine_cdm_component_installer.cc:301:
.AppendASCII(kWidevineCdmFileName));
Do we want to log if this returns false?

[commit-bot: I haz the power, 2016-03-24 00:30:45]

Description was changed from

==========
Add some more logging to help diagnise component update issues.

Specifically, add more logging to CDM installer.

BUG=597289
==========

to

==========
Add some more logging to help diagnise component update issues.

Specifically, add more logging to CDM installer.

BUG=597289
==========

[commit-bot: I haz the power, 2016-03-24 00:30:46]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-03-24 00:37:01]

Description was changed from

==========
Add some more logging to help diagnise component update issues.

Specifically, add more logging to CDM installer.

BUG=597289
==========

to

==========
Add some more logging to help diagnise component update issues.

Specifically, add more logging to CDM installer.

BUG=597289

Committed: https://crrev.com/1a34fd0293910fcb86f7c4366b8bbb6a2e3e9b6d
Cr-Commit-Position: refs/heads/master@{#382988}
==========

[commit-bot: I haz the power, 2016-03-24 00:37:02]

Patchset 1 (id:??) landed as
https://crrev.com/1a34fd0293910fcb86f7c4366b8bbb6a2e3e9b6d
Cr-Commit-Position: refs/heads/master@{#382988}

[Sorin Jianu, 2016-03-24 00:41:24]

https://codereview.chromium.org/1830023002/diff/1/chrome/browser/component_up...
File chrome/browser/component_updater/widevine_cdm_component_installer.cc
(right):

https://codereview.chromium.org/1830023002/diff/1/chrome/browser/component_up...
chrome/browser/component_updater/widevine_cdm_component_installer.cc:301:
.AppendASCII(kWidevineCdmFileName));
On 2016/03/24 00:22:54, xhwang wrote:
> Do we want to log if this returns false?

We do. It is logged by the implementation of the default component installer at
line 89.

Where possible, I tried to avoid duplicating log statements in the release
build.

[xhwang, 2016-03-24 00:52:04]

https://codereview.chromium.org/1830023002/diff/1/chrome/browser/component_up...
File chrome/browser/component_updater/widevine_cdm_component_installer.cc
(right):

https://codereview.chromium.org/1830023002/diff/1/chrome/browser/component_up...
chrome/browser/component_updater/widevine_cdm_component_installer.cc:301:
.AppendASCII(kWidevineCdmFileName));
On 2016/03/24 00:41:24, Sorin Jianu wrote:
> On 2016/03/24 00:22:54, xhwang wrote:
> > Do we want to log if this returns false?
> 
> We do. It is logged by the implementation of the default component installer
at
> line 89.
> 
> Where possible, I tried to avoid duplicating log statements in the release
> build.

Got it. Thanks!