Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4047)

Unified Diff: chrome/browser/component_updater/widevine_cdm_component_installer.cc

Issue 1830023002: Add some more logging to help diagnise component update issues. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@brand
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/component_updater/default_component_installer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/component_updater/widevine_cdm_component_installer.cc
diff --git a/chrome/browser/component_updater/widevine_cdm_component_installer.cc b/chrome/browser/component_updater/widevine_cdm_component_installer.cc
index 68c6d589cd267ddb0b29d9ecfc3c07431cc4d6f3..8f74a949b0fdc85ceb9c1a9dd78864c9b2e2f250 100644
--- a/chrome/browser/component_updater/widevine_cdm_component_installer.cc
+++ b/chrome/browser/component_updater/widevine_cdm_component_installer.cc
@@ -280,7 +280,7 @@ void WidevineCdmComponentInstallerTraits::ComponentReady(
const base::FilePath& path,
scoped_ptr<base::DictionaryValue> manifest) {
if (!IsCompatibleWithChrome(*manifest)) {
- DLOG(WARNING) << "Installed Widevine CDM component is incompatible.";
+ VLOG(1) << "Installed Widevine CDM component is incompatible.";
return;
}
@@ -328,6 +328,10 @@ void WidevineCdmComponentInstallerTraits::UpdateCdmAdapter(
GetPlatformDirectory(cdm_install_dir)
.AppendASCII(kWidevineCdmAdapterFileName);
+ VLOG(1) << "UpdateCdmAdapter: version" << cdm_version.GetString()
+ << " adapter_install_path=" << adapter_install_path.AsUTF8Unsafe()
+ << " adapter_version_path=" << adapter_version_path.AsUTF8Unsafe();
+
const std::string chrome_version = version_info::GetVersionNumber();
DCHECK(!chrome_version.empty());
std::string adapter_version;
@@ -338,14 +342,14 @@ void WidevineCdmComponentInstallerTraits::UpdateCdmAdapter(
adapter_version_path, chrome_version.data(), chrome_version.size());
if (bytes_written < 0 ||
static_cast<size_t>(bytes_written) != chrome_version.size()) {
- DLOG(WARNING) << "Failed to write Widevine CDM adapter version file.";
+ PLOG(WARNING) << "Failed to write Widevine CDM adapter version file.";
// Ignore version file writing failure and try to copy the CDM adapter.
}
base::FilePath adapter_source_path;
PathService::Get(chrome::FILE_WIDEVINE_CDM_ADAPTER, &adapter_source_path);
if (!base::CopyFile(adapter_source_path, adapter_install_path)) {
- DLOG(WARNING) << "Failed to copy Widevine CDM adapter.";
+ PLOG(WARNING) << "Failed to copy Widevine CDM adapter.";
return;
}
}
« no previous file with comments | « no previous file | components/component_updater/default_component_installer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698