Move passwords and password exceptions list into a sub page.

Move passwords and password exceptions list into a sub page.

BUG=595574
Committed: https://crrev.com/cb3880246bcb734401a374ca9c15af5a815196d9
Cr-Commit-Position: refs/heads/master@{#383187}

[hcarmona, 2016-03-23 22:43:56]

hcarmona@chromium.org changed reviewers:
+ michaelpg@chromium.org

[hcarmona, 2016-03-23 22:43:56]

Can you take a look at this CL?

I took at look at your CL (http://crrev.com/1826683002).

It looks easy to change this to use the dom-if template instead. Should
I make this CL dependent on yours and make the change, or should we try
to land this one first?

I also updated this page to use the I18nBehavior.

[michaelpg, 2016-03-24 20:45:53]

Thanks for using I18nBehavior, that'll help with dom-if's. I don't know when my
CL will land, so don't worry about compatibility.

https://codereview.chromium.org/1829993002/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html
(right):

https://codereview.chromium.org/1829993002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html:5:
<link rel="import"
href="chrome://resources/cr_elements/cr_expand_button/cr_expand_button.html">
remove

https://codereview.chromium.org/1829993002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html:6:
<link rel="import"
href="chrome://resources/polymer/v1_0/iron-collapse/iron-collapse.html">
remove

https://codereview.chromium.org/1829993002/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
(right):

https://codereview.chromium.org/1829993002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js:88:
*   password_manager_enabled: !{value: !{boolean}},
see PrefObject instead of {value: ...}

https://codereview.chromium.org/1829993002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js:101:
I18nBehavior,
PrefsBehavior

https://codereview.chromium.org/1829993002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js:181:
//   enabled.
nit: no continuation indent for simple content

https://codereview.chromium.org/1829993002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js:183:
this.prefs.profile.password_manager_enabled.value)
We generally use PrefsBehavior.getPref to provide run-time verification of
preferences (as opposed to compile-time, which doesn't really work because
you're making it up in the @type)

See other settings examples for getPref/setPrefValue usage.

https://codereview.chromium.org/1829993002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js:183:
this.prefs.profile.password_manager_enabled.value)
nit: {} for multi-line if's

[hcarmona, 2016-03-24 21:29:26]

Applied feedback.

https://codereview.chromium.org/1829993002/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html
(right):

https://codereview.chromium.org/1829993002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html:5:
<link rel="import"
href="chrome://resources/cr_elements/cr_expand_button/cr_expand_button.html">
On 2016/03/24 20:45:53, michaelpg wrote:
> remove

Done.

https://codereview.chromium.org/1829993002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.html:6:
<link rel="import"
href="chrome://resources/polymer/v1_0/iron-collapse/iron-collapse.html">
On 2016/03/24 20:45:53, michaelpg wrote:
> remove

Done.

https://codereview.chromium.org/1829993002/diff/1/chrome/browser/resources/se...
File
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
(right):

https://codereview.chromium.org/1829993002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js:88:
*   password_manager_enabled: !{value: !{boolean}},
On 2016/03/24 20:45:53, michaelpg wrote:
> see PrefObject instead of {value: ...}

Done.

https://codereview.chromium.org/1829993002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js:101:
I18nBehavior,
On 2016/03/24 20:45:53, michaelpg wrote:
> PrefsBehavior

Cool! Done.

https://codereview.chromium.org/1829993002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js:181:
//   enabled.
On 2016/03/24 20:45:53, michaelpg wrote:
> nit: no continuation indent for simple content

Done.

https://codereview.chromium.org/1829993002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js:183:
this.prefs.profile.password_manager_enabled.value)
On 2016/03/24 20:45:53, michaelpg wrote:
> nit: {} for multi-line if's

Done.

https://codereview.chromium.org/1829993002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js:183:
this.prefs.profile.password_manager_enabled.value)
On 2016/03/24 20:45:53, michaelpg wrote:
> We generally use PrefsBehavior.getPref to provide run-time verification of
> preferences (as opposed to compile-time, which doesn't really work because
> you're making it up in the @type)
> 
> See other settings examples for getPref/setPrefValue usage.

Done.

[michaelpg, 2016-03-24 22:29:35]

lgtm, aside from an incorrect @type I think

https://codereview.chromium.org/1829993002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
(right):

https://codereview.chromium.org/1829993002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js:99:
* @type {!chrome.settingsPrivate.PrefObject}
not quite: it's an Object whose non-leaf nodes are Objects (recursive) and leaf
nodes are PrefObjects. probably better not to try to type it :-)

[hcarmona, 2016-03-24 22:47:57]

https://codereview.chromium.org/1829993002/diff/20001/chrome/browser/resource...
File
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
(right):

https://codereview.chromium.org/1829993002/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js:99:
* @type {!chrome.settingsPrivate.PrefObject}
On 2016/03/24 22:29:35, michaelpg wrote:
> not quite: it's an Object whose non-leaf nodes are Objects (recursive) and
leaf
> nodes are PrefObjects. probably better not to try to type it :-)

SG, I've removed the @type since I'm not using it in JS anyways.

[hcarmona, 2016-03-24 22:48:26]

The CQ bit was checked by hcarmona@chromium.org

[hcarmona, 2016-03-24 22:48:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
michaelpg@chromium.org
Link to the patchset: https://codereview.chromium.org/1829993002/#ps40001
(title: "nit")

[commit-bot: I haz the power, 2016-03-24 22:48:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1829993002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1829993002/40001

[commit-bot: I haz the power, 2016-03-24 23:33:59]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-24 23:35:29]

Description was changed from

==========
Move passwords and password exceptions list into a sub page.

BUG=595574
==========

to

==========
Move passwords and password exceptions list into a sub page.

BUG=595574

Committed: https://crrev.com/cb3880246bcb734401a374ca9c15af5a815196d9
Cr-Commit-Position: refs/heads/master@{#383187}
==========

[commit-bot: I haz the power, 2016-03-24 23:35:30]

Patchset 3 (id:??) landed as
https://crrev.com/cb3880246bcb734401a374ca9c15af5a815196d9
Cr-Commit-Position: refs/heads/master@{#383187}