Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4216)

Unified Diff: chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js

Issue 1829993002: Move passwords and password exceptions list into a sub page. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
diff --git a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
index 609c4f86b73b944d79e11757e156bb73dd92b28f..a6853f054ca2e6fb6cd002ae081ea5619908449a 100644
--- a/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
+++ b/chrome/browser/resources/settings/passwords_and_forms_page/passwords_and_forms_page.js
@@ -88,6 +88,11 @@ PasswordManagerImpl.prototype = {
Polymer({
is: 'settings-passwords-and-forms-page',
+ behaviors: [
+ I18nBehavior,
+ PrefsBehavior,
+ ],
+
properties: {
/** Preferences state. */
prefs: {
@@ -95,6 +100,12 @@ Polymer({
notify: true,
},
+ /** The current active route. */
+ currentRoute: {
+ type: Object,
+ notify: true,
+ },
+
/**
* An array of passwords to display.
* @type {!Array<!PasswordManager.PasswordUiEntry>}
@@ -112,15 +123,6 @@ Polymer({
type: Array,
value: function() { return []; },
},
-
- /**
- * Whether the password section section is opened or not.
- * @type {boolean}
- */
- passwordsOpened: {
- type: Boolean,
- value: false,
- },
},
listeners: {
@@ -157,5 +159,19 @@ Polymer({
removeSavedPassword_: function(event) {
this.passwordManager_.removeSavedPassword(event.detail);
},
+
+ /**
+ * Shows the manage passwords sub page.
+ * @param {!Event} event
+ * @private
+ */
+ onPasswordsTap_: function(event) {
+ // Ignore clicking on the toggle button and only expand if the manager is
+ // enabled.
+ if (Polymer.dom(event).localTarget != this.$.passwordToggle &&
+ this.getPref('profile.password_manager_enabled').value) {
+ this.$.pages.setSubpageChain(['manage-passwords']);
+ }
+ },
});
})();

Powered by Google App Engine
This is Rietveld 408576698