Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 1829933002: Move PrivateKeyInfoCodec to rsa_private_key_nss.cc (Closed)

Created:
4 years, 9 months ago by davidben
Modified:
4 years, 9 months ago
Reviewers:
nharper
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move PrivateKeyInfoCodec to rsa_private_key_nss.cc It's only used by that one file. BUG=580653 Committed: https://crrev.com/c8a44434aaa8efe3621cbda4722c7527378fb6d8 Cr-Commit-Position: refs/heads/master@{#382979}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix iOS build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+481 lines, -527 lines) Patch
M crypto/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M crypto/crypto.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M crypto/rsa_private_key.h View 1 chunk +0 lines, -136 lines 0 comments Download
D crypto/rsa_private_key.cc View 1 chunk +0 lines, -389 lines 0 comments Download
M crypto/rsa_private_key_nss.cc View 1 2 chunks +481 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
davidben
4 years, 9 months ago (2016-03-23 19:51:43 UTC) #2
nharper
lgtm % trybots https://codereview.chromium.org/1829933002/diff/1/crypto/rsa_private_key_nss.cc File crypto/rsa_private_key_nss.cc (right): https://codereview.chromium.org/1829933002/diff/1/crypto/rsa_private_key_nss.cc#newcode58 crypto/rsa_private_key_nss.cc:58: static const uint8_t kNullTag = 0x05; ...
4 years, 9 months ago (2016-03-23 22:08:14 UTC) #3
davidben
https://codereview.chromium.org/1829933002/diff/1/crypto/rsa_private_key_nss.cc File crypto/rsa_private_key_nss.cc (right): https://codereview.chromium.org/1829933002/diff/1/crypto/rsa_private_key_nss.cc#newcode58 crypto/rsa_private_key_nss.cc:58: static const uint8_t kNullTag = 0x05; On 2016/03/23 22:08:14, ...
4 years, 9 months ago (2016-03-23 22:23:50 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829933002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829933002/20001
4 years, 9 months ago (2016-03-23 22:24:56 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-23 23:55:19 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 23:56:27 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c8a44434aaa8efe3621cbda4722c7527378fb6d8
Cr-Commit-Position: refs/heads/master@{#382979}

Powered by Google App Engine
This is Rietveld 408576698