Issue 1829853002: One of the outstanding TODO items from our fix to redirect navigations to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1829853002: One of the outstanding TODO items from our fix to redirect navigations to (Closed)

Created:
4 years, 9 months ago by Pete Williamson

Modified:
4 years, 9 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2661

Target Ref:
refs/pending/branch-heads/2661

Project:
chromium

Visibility:
Public.

One of the outstanding TODO items from our fix to redirect navigations to offline pages was to switch from the provisional load events to use the newer navigation events. This change switches to the new events, and adds a working test. BUG=591150 Review URL: https://codereview.chromium.org/1754333002 Cr-Commit-Position: refs/heads/master@{#379725} (cherry picked from commit 2ec1dfed7c0e8e9d29ce1c0366321426a8c1b489) Committed: https://chromium.googlesource.com/chromium/src/+/00ff65bb8d9ece36057585c3a31439adbfd79d1f

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -20 lines)			Patch
M	chrome/browser/android/offline_pages/offline_page_tab_helper.h	View	1 chunk	+2 lines, -6 lines	0 comments	Download
M	chrome/browser/android/offline_pages/offline_page_tab_helper.cc	View	2 chunks	+6 lines, -10 lines	0 comments	Download
M	chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc	View	1 chunk	+8 lines, -4 lines	0 comments	Download

Total messages: 2 (1 generated)

Pete Williamson

4 years, 9 months ago (2016-03-23 18:15:55 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
00ff65bb8d9ece36057585c3a31439adbfd79d1f.