Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(219)

Issue 1754333002: Switch to use Navigation events instead of provisional load events (Closed)

Created:
4 years, 9 months ago by Pete Williamson
Modified:
4 years, 9 months ago
Reviewers:
jianli, nasko
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

One of the outstanding TODO items from our fix to redirect navigations to offline pages was to switch from the provisional load events to use the newer navigation events. This change switches to the new events, and adds a working test. BUG=591150 Committed: https://crrev.com/2ec1dfed7c0e8e9d29ce1c0366321426a8c1b489 Cr-Commit-Position: refs/heads/master@{#379725}

Patch Set 1 #

Patch Set 2 : remove snackbar changes #

Patch Set 3 : Get DidFinishNavigation test working #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -20 lines) Patch
M chrome/browser/android/offline_pages/offline_page_tab_helper.h View 1 chunk +2 lines, -6 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_tab_helper.cc View 1 2 2 chunks +6 lines, -10 lines 0 comments Download
M chrome/browser/android/offline_pages/offline_page_tab_helper_unittest.cc View 1 2 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
Pete Williamson
JianLi@, Nasko@, this is working now, please take a look! Thanks.
4 years, 9 months ago (2016-03-07 20:22:36 UTC) #5
nasko
Thanks for following up on this and I'm sorry for the hassle that it was. ...
4 years, 9 months ago (2016-03-07 23:21:27 UTC) #6
jianli
lgtm
4 years, 9 months ago (2016-03-08 00:09:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1754333002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1754333002/40001
4 years, 9 months ago (2016-03-08 00:10:40 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/34644)
4 years, 9 months ago (2016-03-08 01:54:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1754333002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1754333002/40001
4 years, 9 months ago (2016-03-08 01:55:57 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-08 03:57:16 UTC) #15
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 03:59:27 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/2ec1dfed7c0e8e9d29ce1c0366321426a8c1b489
Cr-Commit-Position: refs/heads/master@{#379725}

Powered by Google App Engine
This is Rietveld 408576698