Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(768)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1829823002: Replace usages of DEPRECATED_java_in_dir with java_files (Closed)

Created:
4 years, 9 months ago by agrieve
Modified:
4 years, 9 months ago
Reviewers:
pkotwicz, brettw
CC:
chromium-reviews, zea+watch_chromium.org, posciak+watch_chromium.org, johnme+watch_chromium.org, noyau+watch_chromium.org, wifiprefetch-reviews_google.com, mlamouri+watch-media_chromium.org, tim+watch_chromium.org, cbentzel+watch_chromium.org, toyoshim+midi_chromium.org, samuong+watch_chromium.org, jam, darin-cc_chromium.org, jbudorick+watch_chromium.org, mlamouri+watch-content_chromium.org, Peter Beverloo, feature-media-reviews_chromium.org, asvitkine+watch_chromium.org, mkwst+moarreviews-shell_chromium.org, jochen+watch_chromium.org, tfarina, maxbogue+watch_chromium.org, avayvod+watch_chromium.org, mcasas+watch_chromium.org, plaree+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace usages of DEPRECATED_java_in_dir with java_files BUG=484854 Committed: https://crrev.com/696e6a571b4db1a966ac7b49260eaa47a1ba9bd4 Cr-Commit-Position: refs/heads/master@{#382905}

Patch Set 1 #

Patch Set 2 : missed one somehow #

Total comments: 2

Patch Set 3 : zap random comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1936 lines, -58 lines) Patch
M base/BUILD.gn View 3 chunks +103 lines, -3 lines 0 comments Download
M base/android/jni_generator/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M build/android/rezip/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/BUILD.gn View 1 2 4 chunks +19 lines, -3 lines 0 comments Download
A chrome/android/java_sources.gni View 1 chunk +1154 lines, -0 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/test/webview_shell/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M components/bookmarks/common/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/cronet/android/BUILD.gn View 3 chunks +35 lines, -3 lines 0 comments Download
M components/gcm_driver/android/BUILD.gn View 1 chunk +6 lines, -1 line 0 comments Download
M components/invalidation/impl/BUILD.gn View 2 chunks +9 lines, -2 lines 0 comments Download
M components/navigation_interception/android/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M components/precache/android/BUILD.gn View 2 chunks +9 lines, -2 lines 0 comments Download
M components/service_tab_launcher/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/signin/core/browser/android/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M components/variations/android/BUILD.gn View 1 chunk +6 lines, -1 line 0 comments Download
M components/web_contents_delegate_android/BUILD.gn View 1 chunk +5 lines, -1 line 0 comments Download
M content/public/android/BUILD.gn View 2 chunks +204 lines, -2 lines 0 comments Download
M content/public/test/android/BUILD.gn View 1 chunk +24 lines, -1 line 0 comments Download
M content/shell/android/BUILD.gn View 5 chunks +22 lines, -5 lines 0 comments Download
M content/test/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M media/base/android/BUILD.gn View 1 chunk +9 lines, -1 line 0 comments Download
M media/capture/video/android/BUILD.gn View 1 chunk +9 lines, -1 line 0 comments Download
M media/midi/BUILD.gn View 1 chunk +8 lines, -1 line 0 comments Download
M net/android/BUILD.gn View 3 chunks +38 lines, -3 lines 0 comments Download
M printing/BUILD.gn View 1 chunk +10 lines, -1 line 0 comments Download
M sync/BUILD.gn View 1 chunk +6 lines, -1 line 0 comments Download
M sync/android/BUILD.gn View 2 chunks +24 lines, -2 lines 0 comments Download
M testing/android/native_test/BUILD.gn View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/android_data_chart/BUILD.gn View 1 chunk +10 lines, -1 line 0 comments Download
M third_party/android_media/BUILD.gn View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/android_swipe_refresh/BUILD.gn View 1 chunk +5 lines, -1 line 0 comments Download
M third_party/cacheinvalidation/BUILD.gn View 1 chunk +96 lines, -1 line 0 comments Download
M third_party/custom_tabs_client/BUILD.gn View 1 2 chunks +17 lines, -4 lines 0 comments Download
M tools/android/customtabs_benchmark/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M tools/android/memconsumer/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M ui/android/BUILD.gn View 2 chunks +73 lines, -2 lines 0 comments Download
M url/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Issue 1543003005 Patch 1

Messages

Total messages: 14 (7 generated)
agrieve
4 years, 9 months ago (2016-03-23 17:51:45 UTC) #2
pkotwicz
LGTM https://codereview.chromium.org/1829823002/diff/20001/chrome/android/BUILD.gn File chrome/android/BUILD.gn (right): https://codereview.chromium.org/1829823002/diff/20001/chrome/android/BUILD.gn#newcode387 chrome/android/BUILD.gn:387: # From java_sources.gni. Why is the comment here?
4 years, 9 months ago (2016-03-23 18:15:23 UTC) #5
brettw
rs lgtm I was always wondering what was going to happen with this DEPRECATED variable ...
4 years, 9 months ago (2016-03-23 18:23:48 UTC) #6
agrieve
https://codereview.chromium.org/1829823002/diff/20001/chrome/android/BUILD.gn File chrome/android/BUILD.gn (right): https://codereview.chromium.org/1829823002/diff/20001/chrome/android/BUILD.gn#newcode387 chrome/android/BUILD.gn:387: # From java_sources.gni. On 2016/03/23 18:15:23, pkotwicz wrote: > ...
4 years, 9 months ago (2016-03-23 18:27:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829823002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829823002/40001
4 years, 9 months ago (2016-03-23 18:44:01 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-23 19:54:55 UTC) #12
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 19:56:18 UTC) #14
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/696e6a571b4db1a966ac7b49260eaa47a1ba9bd4
Cr-Commit-Position: refs/heads/master@{#382905}

Powered by Google App Engine
This is Rietveld 408576698