Issue 18298012: Check for scheduled exceptions after a failed-access-check callback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 18298012: Check for scheduled exceptions after a failed-access-check callback. (Closed)

Created:
7 years, 5 months ago by Yang

Modified:
7 years, 5 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Check for scheduled exceptions after a failed-access-check callback. R=verwaest@chromium.org BUG=v8:2524

Patch Set 2 : addressed comment #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+156 lines, -49 lines)			Patch
M	src/handles.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/objects.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.cc	View		11 chunks	+13 lines, -2 lines	0 comments	Download
M	src/runtime.cc	View	1	14 chunks	+45 lines, -23 lines	0 comments	Download
M	test/cctest/test-api.cc	View		2 chunks	+93 lines, -23 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Toon Verwaest

lgtm with nit. https://codereview.chromium.org/18298012/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/18298012/diff/1/src/runtime.cc#newcode5445 src/runtime.cc:5445: return isolate->heap()->true_value(); ASSERT that there can't ...

7 years, 5 months ago (2013-07-12 11:30:39 UTC) #2

Yang

7 years, 5 months ago (2013-07-12 11:43:27 UTC) #3

On 2013/07/12 11:30:39, Toon Verwaest wrote:
> lgtm with nit.
> 
> https://codereview.chromium.org/18298012/diff/1/src/runtime.cc
> File src/runtime.cc (right):
> 
> https://codereview.chromium.org/18298012/diff/1/src/runtime.cc#newcode5445
> src/runtime.cc:5445: return isolate->heap()->true_value();
> ASSERT that there can't be a scheduled exception here.

Committed as r15643.

Expand Messages | Collapse Messages

Issue 18298012: Check for scheduled exceptions after a failed-access-check callback. (Closed)

Description

Patch Set 1 #

Patch Set 2 : addressed comment #

Messages