Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Side by Side Diff: src/handles.cc

Issue 18298012: Check for scheduled exceptions after a failed-access-check callback. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comment Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 632 matching lines...) Expand 10 before | Expand all | Expand 10 after
643 } 643 }
644 644
645 Handle<JSObject> current(JSObject::cast(*p), isolate); 645 Handle<JSObject> current(JSObject::cast(*p), isolate);
646 646
647 // Check access rights if required. 647 // Check access rights if required.
648 if (current->IsAccessCheckNeeded() && 648 if (current->IsAccessCheckNeeded() &&
649 !isolate->MayNamedAccess(*current, 649 !isolate->MayNamedAccess(*current,
650 isolate->heap()->undefined_value(), 650 isolate->heap()->undefined_value(),
651 v8::ACCESS_KEYS)) { 651 v8::ACCESS_KEYS)) {
652 isolate->ReportFailedAccessCheck(*current, v8::ACCESS_KEYS); 652 isolate->ReportFailedAccessCheck(*current, v8::ACCESS_KEYS);
653 if (isolate->has_scheduled_exception()) {
654 isolate->PromoteScheduledException();
655 *threw = true;
656 }
653 break; 657 break;
654 } 658 }
655 659
656 // Compute the element keys. 660 // Compute the element keys.
657 Handle<FixedArray> element_keys = 661 Handle<FixedArray> element_keys =
658 isolate->factory()->NewFixedArray(current->NumberOfEnumElements()); 662 isolate->factory()->NewFixedArray(current->NumberOfEnumElements());
659 current->GetEnumElementKeys(*element_keys); 663 current->GetEnumElementKeys(*element_keys);
660 content = UnionOfKeys(content, element_keys); 664 content = UnionOfKeys(content, element_keys);
661 ASSERT(ContainsOnlyValidKeys(content)); 665 ASSERT(ContainsOnlyValidKeys(content));
662 666
(...skipping 248 matching lines...) Expand 10 before | Expand all | Expand 10 after
911 data->next = prev_next_; 915 data->next = prev_next_;
912 data->limit = prev_limit_; 916 data->limit = prev_limit_;
913 #ifdef DEBUG 917 #ifdef DEBUG
914 handles_detached_ = true; 918 handles_detached_ = true;
915 #endif 919 #endif
916 return deferred; 920 return deferred;
917 } 921 }
918 922
919 923
920 } } // namespace v8::internal 924 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698