Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1829753004: Splitting up wait_for_device into two pieces (Closed)

Created:
4 years, 9 months ago by kjlubick
Modified:
4 years, 9 months ago
Reviewers:
borenet, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -78 lines) Patch
M infra/bots/flavor/android_flavor.py View 1 chunk +6 lines, -0 lines 1 comment Download
A + platform_tools/android/bin/adb_wait_for_charge View 3 chunks +2 lines, -10 lines 0 comments Download
M platform_tools/android/bin/adb_wait_for_device View 2 chunks +2 lines, -68 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
kjlubick
4 years, 9 months ago (2016-03-24 19:55:58 UTC) #3
borenet
LGTM https://codereview.chromium.org/1829753004/diff/1/infra/bots/flavor/android_flavor.py File infra/bots/flavor/android_flavor.py (right): https://codereview.chromium.org/1829753004/diff/1/infra/bots/flavor/android_flavor.py#newcode1 infra/bots/flavor/android_flavor.py:1: #!/usr/bin/env python FTR this file is going away ...
4 years, 9 months ago (2016-03-25 11:40:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829753004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829753004/1
4 years, 9 months ago (2016-03-25 12:05:05 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-25 12:22:43 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2e59f1f2fd497367585374eb20f5c04d92ae6d26

Powered by Google App Engine
This is Rietveld 408576698