Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Unified Diff: platform_tools/android/bin/adb_wait_for_device

Issue 1829753004: Splitting up wait_for_device into two pieces (Closed) Base URL: https://skia.googlesource.com/skia@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: platform_tools/android/bin/adb_wait_for_device
diff --git a/platform_tools/android/bin/adb_wait_for_device b/platform_tools/android/bin/adb_wait_for_device
index a1f8c1645e1b2053b5370ed3fdf51f5348425a02..32a517b691fc89666a0907dda8df56a9f735e82f 100755
--- a/platform_tools/android/bin/adb_wait_for_device
+++ b/platform_tools/android/bin/adb_wait_for_device
@@ -1,68 +1,11 @@
#!/bin/bash
#
-# Wait for the device to be ready to run tests.
+# Wait for the device to be connected.
SCRIPT_DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
source $SCRIPT_DIR/android_setup.sh
source $SCRIPT_DIR/utils/setup_adb.sh
-# Helper function used by get_battery_level. Parses the battery level from
-# dumpsys output.
-function _parse_battery_level {
- SPLIT=( $@ )
-
- HAS_BATTERY=1
- LEVEL=""
-
- for i in "${!SPLIT[@]}"; do
- if [ "${SPLIT[$i]}" = "level:" ]; then
- LEVEL="${SPLIT[$i+1]}"
- fi
- if [ "${SPLIT[$i]}" = "present:" ]; then
- PRESENT="$(echo "${SPLIT[$i+1]}" | tr -d '\r')"
- if [ "$PRESENT" = "0" ]; then
- HAS_BATTERY=0
- fi
- if [ "$PRESENT" = "false" ]; then
- HAS_BATTERY=0
- fi
- fi
- done
-
- if [ "$HAS_BATTERY" = "1" ]; then
- echo "$LEVEL" | tr -d '\r'
- return
- fi
- # If there's no battery, report a full battery.
- echo "Device has no battery." 1>&2
- echo "100"
-}
-
-# Echo the battery level percentage of the attached Android device.
-function get_battery_level {
- STATS="$($ADB $DEVICE_SERIAL shell dumpsys batteryproperties)"
- SPLIT=( $STATS )
- RV="$(_parse_battery_level ${SPLIT[@]})"
- if [ -n "$RV" ]; then
- echo "$RV"
- return
- fi
-
- echo "Battery level fallback..." 1>&2
-
- STATS="$($ADB $DEVICE_SERIAL shell dumpsys battery)"
- SPLIT=( $STATS )
- RV="$(_parse_battery_level ${SPLIT[@]})"
- if [ "$RV" != "-1" ]; then
- echo "$RV"
- return
- fi
-
- echo "Could not determine battery level!" 1>&2
- # Just exit to prevent hanging forever or failing the build.
- echo "0"
-}
-
set -e
# Wait for the device to be connected and fully booted.
@@ -71,13 +14,4 @@ while [ "$($ADB $DEVICE_SERIAL shell getprop sys.boot_completed | tr -d '\r')" !
sleep 5
done
-# Wait for battery charge.
-DESIRED_BATTERY_LEVEL=80
-CURRENT_BATTERY_LEVEL="$(get_battery_level)"
-while [ "${CURRENT_BATTERY_LEVEL}" -lt "${DESIRED_BATTERY_LEVEL}" ]; do
- echo "Battery level is ${CURRENT_BATTERY_LEVEL}; waiting to charge to ${DESIRED_BATTERY_LEVEL}"
- sleep 5
- CURRENT_BATTERY_LEVEL="$(get_battery_level)"
-done
-
-echo "Ready!"
+echo "Connected!"
« infra/bots/flavor/android_flavor.py ('K') | « platform_tools/android/bin/adb_wait_for_charge ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698