Fix missing fields in GestureScrollBegin/Update/End event conversions.

Fix missing fields in GestureScrollBegin/Update/End event conversions.

Some of the fields were missing from the event conversion path that
occurs when a plugin is used. This caused fields to be populated
with the default value. As a result the default values enabled
overscroll scrolling when using a low precision delta
mouse wheel with an MacOSX machine.

The bug did not indicate which precision of mouse was being
used but overscrolling for PDF files with a touchpad or a magic
mouse (which have high precision deltas) still enable
elastic overscroll; but that is consistent with MacOSX.
This is a behavioural change for MacOSX but is consistent
with Safari when using a high precision mouse.

BUG=596778
Committed: https://crrev.com/c1d91e8f7cd46f1cb68ec09e49d4de5c90175d6c
Cr-Commit-Position: refs/heads/master@{#382901}

[dtapuska, 2016-03-23 16:47:35]

Description was changed from

==========
Fix missing fields in GestureScrollBegin/Update/End event conversions.

Some of the fields were missing from the event conversion path that
occurs when a plugin is used. This caused fields to be populated
with the default value. As a result the default values enabled
overscroll scrolling when using a low precision delta
mouse wheel with an MacOSX machine.

Overscrolling for PDF files with a touchpad or a magic
mouse that have high precision deltas still enable
elastic overscroll; but that is consisten with the MacOSX.

BUG=596778
==========

to

==========
Fix missing fields in GestureScrollBegin/Update/End event conversions.

Some of the fields were missing from the event conversion path that
occurs when a plugin is used. This caused fields to be populated
with the default value. As a result the default values enabled
overscroll scrolling when using a low precision delta
mouse wheel with an MacOSX machine.

Overscrolling for PDF files with a touchpad or a magic
mouse that have high precision deltas still enable
elastic overscroll; but that is consisten with the MacOSX.

BUG=596778
==========

[dtapuska, 2016-03-23 16:47:36]

dtapuska@chromium.org changed reviewers:
+ tdresser@chromium.org

[dtapuska, 2016-03-23 16:49:42]

Description was changed from

==========
Fix missing fields in GestureScrollBegin/Update/End event conversions.

Some of the fields were missing from the event conversion path that
occurs when a plugin is used. This caused fields to be populated
with the default value. As a result the default values enabled
overscroll scrolling when using a low precision delta
mouse wheel with an MacOSX machine.

Overscrolling for PDF files with a touchpad or a magic
mouse that have high precision deltas still enable
elastic overscroll; but that is consisten with the MacOSX.

BUG=596778
==========

to

==========
Fix missing fields in GestureScrollBegin/Update/End event conversions.

Some of the fields were missing from the event conversion path that
occurs when a plugin is used. This caused fields to be populated
with the default value. As a result the default values enabled
overscroll scrolling when using a low precision delta
mouse wheel with an MacOSX machine.

Overscrolling for PDF files with a touchpad or a magic
mouse that have high precision deltas still enable
elastic overscroll; but that is consistent with the MacOSX.

BUG=596778
==========

[dtapuska, 2016-03-23 16:49:55]

Description was changed from

==========
Fix missing fields in GestureScrollBegin/Update/End event conversions.

Some of the fields were missing from the event conversion path that
occurs when a plugin is used. This caused fields to be populated
with the default value. As a result the default values enabled
overscroll scrolling when using a low precision delta
mouse wheel with an MacOSX machine.

Overscrolling for PDF files with a touchpad or a magic
mouse that have high precision deltas still enable
elastic overscroll; but that is consistent with the MacOSX.

BUG=596778
==========

to

==========
Fix missing fields in GestureScrollBegin/Update/End event conversions.

Some of the fields were missing from the event conversion path that
occurs when a plugin is used. This caused fields to be populated
with the default value. As a result the default values enabled
overscroll scrolling when using a low precision delta
mouse wheel with an MacOSX machine.

Overscrolling for PDF files with a touchpad or a magic
mouse that have high precision deltas still enable
elastic overscroll; but that is consistent with MacOSX.

BUG=596778
==========

[tdresser, 2016-03-23 16:58:48]

"Overscrolling for PDF files with a touchpad or a magic
mouse that have high precision deltas still enable
elastic overscroll; but that is consisten with the MacOSX."

Is this a behavior change? If so, we should note that clearly.

LGTM

https://codereview.chromium.org/1829743003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/PlatformGestureEvent.h (right):

https://codereview.chromium.org/1829743003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/PlatformGestureEvent.h:223: float m_deltaX;
We should likely add a comment that m_delta{X,Y} mean something different for
GSB than for GSU, as we store the scroll hint separately in WebGestureEvent.

https://codereview.chromium.org/1829743003/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/WebInputEventConversion.cpp (right):

https://codereview.chromium.org/1829743003/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/WebInputEventConversion.cpp:111: case
WebGestureEvent::ScrollUnits::PrecisePixels:
Indentation.

https://codereview.chromium.org/1829743003/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/WebInputEventConversion.cpp:126: case
ScrollGranularity::ScrollByPrecisePixel:
Indentation.

https://codereview.chromium.org/1829743003/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp
(right):

https://codereview.chromium.org/1829743003/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp:1019:
webGestureEvent.resendingPluginId = 2;
Looks like you're missing an expectation for resendingPluginId (and below).

[dtapuska, 2016-03-23 17:23:32]

Description was changed from

==========
Fix missing fields in GestureScrollBegin/Update/End event conversions.

Some of the fields were missing from the event conversion path that
occurs when a plugin is used. This caused fields to be populated
with the default value. As a result the default values enabled
overscroll scrolling when using a low precision delta
mouse wheel with an MacOSX machine.

Overscrolling for PDF files with a touchpad or a magic
mouse that have high precision deltas still enable
elastic overscroll; but that is consistent with MacOSX.

BUG=596778
==========

to

==========
Fix missing fields in GestureScrollBegin/Update/End event conversions.

Some of the fields were missing from the event conversion path that
occurs when a plugin is used. This caused fields to be populated
with the default value. As a result the default values enabled
overscroll scrolling when using a low precision delta
mouse wheel with an MacOSX machine.

The bug did not indicate which precision of mouse was being
used but overscrolling for PDF files with a touchpad or a magic
mouse (which have high precision deltas) still enable
elastic overscroll; but that is consistent with MacOSX.
This is a behavioural change for MacOSX but is consistent
with Safari when using a high precision mouse.

BUG=596778
==========

[dtapuska, 2016-03-23 17:25:30]

https://codereview.chromium.org/1829743003/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/PlatformGestureEvent.h (right):

https://codereview.chromium.org/1829743003/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/PlatformGestureEvent.h:223: float m_deltaX;
On 2016/03/23 16:58:47, tdresser wrote:
> We should likely add a comment that m_delta{X,Y} mean something different for
> GSB than for GSU, as we store the scroll hint separately in WebGestureEvent.

Done.

https://codereview.chromium.org/1829743003/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/WebInputEventConversion.cpp (right):

https://codereview.chromium.org/1829743003/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/WebInputEventConversion.cpp:111: case
WebGestureEvent::ScrollUnits::PrecisePixels:
On 2016/03/23 16:58:47, tdresser wrote:
> Indentation.

This is std blink style.

https://codereview.chromium.org/1829743003/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/WebInputEventConversion.cpp:126: case
ScrollGranularity::ScrollByPrecisePixel:
On 2016/03/23 16:58:47, tdresser wrote:
> Indentation.

This is std blink style.

https://codereview.chromium.org/1829743003/diff/1/third_party/WebKit/Source/w...
File third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp
(right):

https://codereview.chromium.org/1829743003/diff/1/third_party/WebKit/Source/w...
third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp:1019:
webGestureEvent.resendingPluginId = 2;
On 2016/03/23 16:58:47, tdresser wrote:
> Looks like you're missing an expectation for resendingPluginId (and below).

Done.

[dtapuska, 2016-03-23 17:26:00]

dtapuska@chromium.org changed reviewers:
+ rbyers@chromium.org

[Rick Byers, 2016-03-23 18:02:09]

LGTM

[dtapuska, 2016-03-23 18:38:06]

The CQ bit was checked by dtapuska@chromium.org

[dtapuska, 2016-03-23 18:38:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdresser@chromium.org
Link to the patchset: https://codereview.chromium.org/1829743003/#ps20001
(title: "Fix tdresser's comments in patch set 1")

[commit-bot: I haz the power, 2016-03-23 18:38:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1829743003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1829743003/20001

[commit-bot: I haz the power, 2016-03-23 19:34:59]

Description was changed from

==========
Fix missing fields in GestureScrollBegin/Update/End event conversions.

Some of the fields were missing from the event conversion path that
occurs when a plugin is used. This caused fields to be populated
with the default value. As a result the default values enabled
overscroll scrolling when using a low precision delta
mouse wheel with an MacOSX machine.

The bug did not indicate which precision of mouse was being
used but overscrolling for PDF files with a touchpad or a magic
mouse (which have high precision deltas) still enable
elastic overscroll; but that is consistent with MacOSX.
This is a behavioural change for MacOSX but is consistent
with Safari when using a high precision mouse.

BUG=596778
==========

to

==========
Fix missing fields in GestureScrollBegin/Update/End event conversions.

Some of the fields were missing from the event conversion path that
occurs when a plugin is used. This caused fields to be populated
with the default value. As a result the default values enabled
overscroll scrolling when using a low precision delta
mouse wheel with an MacOSX machine.

The bug did not indicate which precision of mouse was being
used but overscrolling for PDF files with a touchpad or a magic
mouse (which have high precision deltas) still enable
elastic overscroll; but that is consistent with MacOSX.
This is a behavioural change for MacOSX but is consistent
with Safari when using a high precision mouse.

BUG=596778
==========

[commit-bot: I haz the power, 2016-03-23 19:35:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-23 19:36:24]

Description was changed from

==========
Fix missing fields in GestureScrollBegin/Update/End event conversions.

Some of the fields were missing from the event conversion path that
occurs when a plugin is used. This caused fields to be populated
with the default value. As a result the default values enabled
overscroll scrolling when using a low precision delta
mouse wheel with an MacOSX machine.

The bug did not indicate which precision of mouse was being
used but overscrolling for PDF files with a touchpad or a magic
mouse (which have high precision deltas) still enable
elastic overscroll; but that is consistent with MacOSX.
This is a behavioural change for MacOSX but is consistent
with Safari when using a high precision mouse.

BUG=596778
==========

to

==========
Fix missing fields in GestureScrollBegin/Update/End event conversions.

Some of the fields were missing from the event conversion path that
occurs when a plugin is used. This caused fields to be populated
with the default value. As a result the default values enabled
overscroll scrolling when using a low precision delta
mouse wheel with an MacOSX machine.

The bug did not indicate which precision of mouse was being
used but overscrolling for PDF files with a touchpad or a magic
mouse (which have high precision deltas) still enable
elastic overscroll; but that is consistent with MacOSX.
This is a behavioural change for MacOSX but is consistent
with Safari when using a high precision mouse.

BUG=596778

Committed: https://crrev.com/c1d91e8f7cd46f1cb68ec09e49d4de5c90175d6c
Cr-Commit-Position: refs/heads/master@{#382901}
==========

[commit-bot: I haz the power, 2016-03-23 19:36:25]

Patchset 2 (id:??) landed as
https://crrev.com/c1d91e8f7cd46f1cb68ec09e49d4de5c90175d6c
Cr-Commit-Position: refs/heads/master@{#382901}