Fix missing fields in GestureScrollBegin/Update/End event conversions.

third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 975 matching lines @@
         EXPECT_EQ(0, platformWheelBuilder.position().y());
         EXPECT_EQ(15, platformWheelBuilder.deltaX());
         EXPECT_EQ(10, platformWheelBuilder.deltaY());
         EXPECT_EQ(PlatformEvent::AltKey, platformWheelBuilder.getModifiers());
         EXPECT_TRUE(platformWheelBuilder.hasPreciseScrollingDeltas());
         EXPECT_FALSE(platformWheelBuilder.canScroll());
         EXPECT_EQ(platformWheelBuilder.getRailsMode(), PlatformEvent::RailsModeVertical);
     }
 }
 
+TEST(WebInputEventConversionTest, PlatformGestureEventBuilder)
+{
+    const std::string baseURL("http://www.test8.com/");
+    const std::string fileName("fixed_layout.html");
+
+    URLTestHelpers::registerMockedURLFromBaseURL(WebString::fromUTF8(baseURL.c_str()), WebString::fromUTF8("fixed_layout.html"));
+    FrameTestHelpers::WebViewHelper webViewHelper;
+    WebViewImpl* webViewImpl = webViewHelper.initializeAndLoad(baseURL + fileName, true);
+    int pageWidth = 640;
+    int pageHeight = 480;
+    webViewImpl->resize(WebSize(pageWidth, pageHeight));
+    webViewImpl->updateAllLifecyclePhases();
+
+    FrameView* view = toLocalFrame(webViewImpl->page()->mainFrame())->view();
+
+    {
+        WebGestureEvent webGestureEvent;
+        webGestureEvent.type = WebInputEvent::GestureScrollBegin;
+        webGestureEvent.x = 0;
+        webGestureEvent.y = 5;
+        webGestureEvent.globalX = 10;
+        webGestureEvent.globalY = 15;
+        webGestureEvent.sourceDevice = WebGestureDeviceTouchpad;
+        webGestureEvent.resendingPluginId = 2;

[tdresser, 2016/03/23 16:58:47]

Looks like you're missing an expectation for resendingPluginId (and below).

[dtapuska, 2016/03/23 17:25:30]

Done.

+        webGestureEvent.data.scrollBegin.inertial = true;
+        webGestureEvent.data.scrollBegin.synthetic = true;
+        webGestureEvent.data.scrollBegin.deltaXHint = 100;
+        webGestureEvent.data.scrollBegin.deltaYHint = 10;
+        webGestureEvent.data.scrollBegin.deltaHintUnits = WebGestureEvent::Pixels;
+
+        PlatformGestureEventBuilder platformGestureBuilder(view, webGestureEvent);
+        EXPECT_EQ(0, platformGestureBuilder.position().x());
+        EXPECT_EQ(5, platformGestureBuilder.position().y());
+        EXPECT_EQ(10, platformGestureBuilder.globalPosition().x());
+        EXPECT_EQ(15, platformGestureBuilder.globalPosition().y());
+        EXPECT_TRUE(platformGestureBuilder.inertial());
+        EXPECT_TRUE(platformGestureBuilder.synthetic());
+        EXPECT_EQ(100, platformGestureBuilder.deltaX());
+        EXPECT_EQ(10, platformGestureBuilder.deltaY());
+        EXPECT_EQ(ScrollGranularity::ScrollByPixel, platformGestureBuilder.deltaUnits());
+    }
+
+    {
+        WebGestureEvent webGestureEvent;
+        webGestureEvent.type = WebInputEvent::GestureScrollEnd;
+        webGestureEvent.x = 0;
+        webGestureEvent.y = 5;
+        webGestureEvent.globalX = 10;
+        webGestureEvent.globalY = 15;
+        webGestureEvent.sourceDevice = WebGestureDeviceTouchpad;
+        webGestureEvent.resendingPluginId = 2;
+        webGestureEvent.data.scrollEnd.inertial = false;
+        webGestureEvent.data.scrollEnd.synthetic = true;
+        webGestureEvent.data.scrollEnd.deltaUnits = WebGestureEvent::Page;
+
+        PlatformGestureEventBuilder platformGestureBuilder(view, webGestureEvent);
+        EXPECT_EQ(0, platformGestureBuilder.position().x());
+        EXPECT_EQ(5, platformGestureBuilder.position().y());
+        EXPECT_EQ(10, platformGestureBuilder.globalPosition().x());
+        EXPECT_EQ(15, platformGestureBuilder.globalPosition().y());
+        EXPECT_FALSE(platformGestureBuilder.inertial());
+        EXPECT_TRUE(platformGestureBuilder.synthetic());
+        EXPECT_EQ(ScrollGranularity::ScrollByPage, platformGestureBuilder.deltaUnits());
+    }
+}
+
 } // namespace blink