Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 1829683002: Revert of 🌈 Android: Run lint using a cache in the output directory (fix-up) (Closed)

Created:
4 years, 9 months ago by aberent
Modified:
4 years, 9 months ago
Reviewers:
jbudorick, agrieve
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of 🌈 Android: Run lint using a cache in the output directory (fix-up) (patchset #2 id:20001 of https://codereview.chromium.org/1824093002/ ) Reason for revert: Breaks on Android 64bit unpublished builders BUG=597251 Original issue's description: > Android: Run lint using a cache in the output directory (fix-up) > > Previous commit forgot to set --cache-dir for GN. > > BUG=583661 > > Committed: https://crrev.com/99748af41ad073389f3f38274a024a830585609c > Cr-Commit-Position: refs/heads/master@{#382699} TBR=jbudorick@chromium.org,agrieve@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=583661 Committed: https://crrev.com/62cc80409b326670a7faafb3db806451fa6cc812 Cr-Commit-Position: refs/heads/master@{#382838}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -65 lines) Patch
M build/android/BUILD.gn View 1 chunk +31 lines, -3 lines 0 comments Download
M build/android/android_lint_cache.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M build/android/gyp/lint.py View 3 chunks +4 lines, -16 lines 0 comments Download
M build/config/android/internal_rules.gni View 2 chunks +28 lines, -45 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
aberent
Created Revert of 🌈 Android: Run lint using a cache in the output directory (fix-up)
4 years, 9 months ago (2016-03-23 12:55:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829683002/1
4 years, 9 months ago (2016-03-23 12:55:38 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-23 12:56:05 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/62cc80409b326670a7faafb3db806451fa6cc812 Cr-Commit-Position: refs/heads/master@{#382838}
4 years, 9 months ago (2016-03-23 12:57:45 UTC) #6
agrieve
4 years, 9 months ago (2016-03-23 14:32:40 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1828693002/ by agrieve@chromium.org.

The reason for reverting is: fixing....

Powered by Google App Engine
This is Rietveld 408576698